[18.0][MIG] stock_orderpoint_generator: Migration to 18.0 - #72
Open
clementmbr wants to merge 25 commits into
Open
[18.0][MIG] stock_orderpoint_generator: Migration to 18.0#72clementmbr wants to merge 25 commits into
clementmbr wants to merge 25 commits into
Conversation
And improve the wording * Add an option to automatically generate rules When a product variant is created with a (or several) rule template(s), it automatically generates (on the fly) the corresponding rule(s). When a rule template is modified, it automatically updates the existing rules of the linked products (it uses the mechanism in place, disable the old and create a fresh one). The latter update is done by a cron because it might take a long time to update all the products reordering rules. * Add documentation * Copy orderpoint views to orderpoint templates Unfortunately we cannot rely on the possibility to copy a view with "inherit_id" + "mode=primary" in Odoo 9.0 in this use case (precisely with a model that is a "copy by prototype"). The explanation: We "copy by prototype" the model "stock.warehouse.orderpoint" to a new "stock.warehouse.orderpoint.template" model (with both _inherit and different _name). Before this commit, we were reusing the stock.warehouse.orderpoint's views, just making the changes needed for the templates. Thing is: when a third (unrelated) addon adds a column on the model, the ORM doesn't add the column in the stock.warehouse.orderpoint.template model. So the templates' views complains about this unexisting field. Therefore, copy-pasting the view ensure that changes on 'stock.warehouse.orderpoint' does not have any side effect on the templates. From Odoo 10.0, the "copy by prototype" reports the changes made on the "prototype" model to the "copy" so we should be able to revert to the "inherit_id" + "mode=primary" views.
…h call create (#466)
With initial wrong values we can carry a computing error to the subsequent moves.
A new option for auto computing minimum and maximum values depending on the actual delivered items for a period of time
The Size attribute is already defined in the point_of_sale module so when both modules are installed an error occurs in the tests. This is solved by changing the name of the attribute in the tests of the stock_orderpoint_generator module. TT41548
Currently translated at 100.0% (90 of 90 strings) Translation: stock-logistics-orderpoint-17.0/stock-logistics-orderpoint-17.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-orderpoint-17-0/stock-logistics-orderpoint-17-0-stock_orderpoint_generator/it/
metaminux
suggested changes
May 15, 2026
metaminux
left a comment
metaminux
left a comment
There was a problem hiding this comment.
Everything is functionally right, even the new reconciliation logic against min/max constraint
Only 2 recommendations from OCA migration guidelines (see my comments inline)
There is also a typo (missing "r" in module's name) in the "first" migration commit message, it should be named :
[MIG] stock_orderpoint_generator: Basic Migration to 18.0
instead of :
[MIG] stock_oderpoint_generator: Basic Migration to 18.0
So nothing totally blocking, but those changes would be appreciated
Regards,
|
Hello @clementmbr Do you need some help on this one ? |
clementmbr
force-pushed
the
18-mig-stock_orderpoint_generator
branch
from
July 24, 2026 11:07
9c38119 to
2427f06
Compare
OCA-git-bot
added
series:18.0
mod:stock_orderpoint_generator
clementmbr
force-pushed
the
18-mig-stock_orderpoint_generator
branch
from
July 24, 2026 11:09
2427f06 to
b4bfbbd
Compare
Member
Author
|
Hi @metaminux ! Thanks for your assertive feedback 🙏 |
metaminux
approved these changes
Jul 24, 2026
Contributor
|
/ocabot migration stock_orderpoint_generator |
Contributor
|
@clementmbr Thanks for this. Could you put version change in migration commit and make module name appear in last commit? Thanks 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
product_min_qty < product_max_qtyauto_same_valuescheck