[16.0][FIX] stock_location_orderpoint: reclaim moves from lower priority orderpoints - #90
Draft
nicolas-delbovier-acsone wants to merge 2 commits into
Conversation
…derpoints When running replenishment for a higher-priority orderpoint after a lower-priority one, existing replenishment moves covering actual demand were causing the procurement engine to skip updating the necessary moves.
Contributor
|
Hi @mt-software-de, @lmignon, |
lmignon
suggested changes
Jul 22, 2026
Comment on lines
+490
to
+492
| replenishment_moves = ( | ||
| self._reclaim_replenishing_moves_from_lower_priority_orderpoints() | ||
| ) |
Contributor
There was a problem hiding this comment.
@nicolas-delbovier-acsone IMO it's semantically wrong to return replenishment moves generated by others orderpoint. This change breaks the api.
nicolas-delbovier-acsone
marked this pull request as draft
July 27, 2026 06:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running replenishment for a higher-priority orderpoint after a lower-priority
one, existing replenishment moves covering actual demand were
causing the procurement engine to skip updating the necessary moves.