Conversation
…omponents by kit when delivery-return-redelivery
…alculation to exclude returned moves
|
Hi @chienandalu, |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
This PR has the |
|
@rousseldenis could you merge this one? |
|
@pedrobaeza could U merge this one? |
pedrobaeza
left a comment
There was a problem hiding this comment.
Don't introduce extra empty lines inside methods, and please reduce AI usage to the minimum, as the code is bloated due to it.
| ) | ||
|
|
||
| kit_moves_to_sum = kit_moves.filtered(lambda x: not x.origin_returned_move_id) | ||
| kit_moves_to_subtract = kit_moves - kit_moves_to_sum |
There was a problem hiding this comment.
Instead of complicating this way, just sum the proper moves.
Fixes #451
This PR contains two commits:
🧩 Context
The problem occurs in the following workflow:
At this point, the system generate another picking and you validate this too, and we noticed that the kit component quantities shown on the delivery slip report were incorrect.
🔍 Root Cause
The issue appears to stem from the calculation of the component quantities per kit during this sequence of operations.
🛠️ Proposed Fix
This PR provides an initial attempt to resolve the incorrect quantity computation. Additional details and discussion can be found in the linked issue.
HT14789
@BinhexTeam