Skip to content

use cloud tiles as fallback #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2022
Merged

use cloud tiles as fallback #44

merged 4 commits into from
May 7, 2022

Conversation

goto-10
Copy link

@goto-10 goto-10 commented May 5, 2022

related issue: #42 (comment)

changes:

  • converts getWorldByName to async function
    • checks for a local map.json first, then falls back to the cloud cdn if enabled (ui.useCloudTiles)
    • if cloud is used _useCloudTiles property is injected into the world data (checked in initMap fn)
  • refactored promise chain in processOp fn a bit to leverage the catch fn to show errors properly

@Fank Fank self-requested a review May 6, 2022 10:48
@indig0fox indig0fox merged commit 35528a4 into OCAP2:ind/leaflet-functionality May 7, 2022
@indig0fox indig0fox linked an issue May 24, 2023 that may be closed by this pull request
Player disconnect counts as death OCAP2/OCAP#71
Open
@indig0fox indig0fox removed a link to an issue May 24, 2023
Player disconnect counts as death OCAP2/OCAP#71
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fank Fank Fank approved these changes

@indig0fox indig0fox indig0fox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goto-10 @Fank @indig0fox @a-sync