Processor.input_files: handle list of pageId #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertsky
requested changes
Oct 9, 2020
There was a problem hiding this comment.
Sorry, I am just seeing this now: We actually have to rewrite the whole function. Up above, we filter by MIME type alone. So whenever (for some list of pageIds) there is even a single page with PAGE annotation, only that page survives.
What we need instead:
find_all_filesfiltering MIME for PAGE orimage/*- aggregate results by page ID, and iterate:
- if the page has a PAGE hit, keep only that
- else if it has a single hit, keep it
- else raise
|
Superseded by #635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.