Conversation
- updated all analyses to use study population rather than target id as this enables subsetting filtering on min prior obs, first in n days, nesting id, age, gender, and date.
minor fixes
- updating vignettes - updating unit tests for main analyses and fixing issues (still need to update results database via migration scripts)
fixing result table creation and uploading for new result tables
-replacing IFNULL with ISNULL - fixing outcomeId is dechal-rechal - fixing manual data tests
- replacing IFNULL with ISNULL
fixing sqrt 0 division
manually specifying risk factor columns to remove mean_diff and st_dev
aiming to fix bigquery int float issue
trying to fix weird union issue only impacting bigquery
adding spacing between UNION and SELECT to fix odd bigquery conversion
fixing missing column from migration and no cohort edge cases
- added setting lookups - changed bit columns to char(1) due to loading issues - changed boolean values to 1/0 for uploading
use restrictWashoutToObs = FALSE in createCharacterizationSettings to ignore observation period for washout
- fixing outcome before TAR - adding option to do washout using outcomes outside of observation period
…dered fixing target/case code for situation where cohorts are not nicely ordered
- replacing row_number with row_id since row_number is a SQL function - adding code to do outcome eras for risk factor analysis - fixing shiny app in Characterization
- added test for outcomeWashoutDays to make sure it is only a single value - edited risk factors/case series so that the minCharacterizationMean is applied after processing (otherwise it can make SMD seem bigger)
preparing to merge into develop
- fixing merge conflict issue where restrictWashoutToObs got added
- updated required OhdsiShinyModules for shiny app - added missing columns to database_meta_data when viewing shiny to prevent annoying error message.
Subset creation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 94.30% 93.77% -0.54%
==========================================
Files 15 16 +1
Lines 3827 3982 +155
==========================================
+ Hits 3609 3734 +125
- Misses 218 248 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you do a pull request, you should always file an issue and make sure the package maintainer agrees that it’s a problem, and is happy with your basic proposal for fixing it. We don’t want you to spend a bunch of time on something that we don’t think is a good idea.
Additional requirements for pull requests:
Adhere to the Developer Guidelines as well as the OHDSI Code Style.
If possible, add unit tests for new functionality you add.
Restrict your pull request to solving the issue at hand. Do not try to 'improve' parts of the code that are not related to the issue. If you feel other parts of the code need better organization, create a separate issue for that.
Make sure you pass R check without errors and warnings before submitting.
Always target the
developbranch, and make sure you are up-to-date with the develop branch.