Lua dataset/v6 #12090
Draft
Lua dataset/v6 #12090
+106
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only useful when debugging. Add a prefix and a stack size indication.
Add optional `thread_init` function support. This function is called per script, per thread to allow a user to initialize the lua state.
dataset.get_ref
gets a reference to an existing dataset
dataset.add
returns 1 if a new entry was added
returns 0 if entry was already in the set
Example:
```
function init (args)
local needs = {}
needs["packet"] = tostring(true)
return needs
end
function thread_init (args)
conn_new, err = dataset.get_ref("conn-seen")
if err ~= nil then
SCLogWarning("dataset warning: " .. err)
return 0
end
end
function match (args)
ipver, srcip, dstip, proto, sp, dp = SCFlowTuple()
str = ipver .. ":<" .. srcip .. ">:<" .. dstip .. ">:" .. dp
ret, err = dataset.add(conn_new, str, #str);
if ret == 1 then
SCLogInfo(str .. " => " .. ret)
end
return ret
end
```
Ticket: OISF#7243.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12090 +/- ##
==========================================
+ Coverage 83.25% 83.28% +0.02%
==========================================
Files 910 910
Lines 257571 257624 +53
==========================================
+ Hits 214450 214559 +109
+ Misses 43121 43065 -56
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23255 |
|
Passed my QA. Ran this PR with SV PR OISF/suricata-verify#2120. Local pipeline 5131, run 627. |
jasonish
reviewed
Nov 12, 2024
| return 1; | ||
| } | ||
|
|
||
| static int LuaDatasetAdd(lua_State *luastate) |
There was a problem hiding this comment.
Related to this function: OISF/suricata-verify#2120 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial dataset support for lua.
https://redmine.openinfosecfoundation.org/issues/7243
SV_BRANCH=OISF/suricata-verify#2120