Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output More Restart File Items #4439

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Output More Restart File Items #4439

wants to merge 3 commits into from

Conversation

bska
Copy link
Member

@bska bska commented Jan 21, 2025

Needed for compatibility.

@bska
Copy link
Member Author

bska commented Jan 21, 2025

Note that despite the somewhat modest size of this PR in terms of number of changed lines, the actual impact is significant. Due to changing the number of items per well (XWEL array), connection (ICON and SCON arrays) or segment (RSEG array), as well as the contents of the INTEHEAD array, this PR breaks more or less every existing regression test. We will need to run a number of tests before we consider merging this. Thanks to @akva2's PR OPM/opm-simulators#5897, however, we have the ability to check that actual simulation results are not impacted by this change–only their on-disk representation in the restart file.

@bska
Copy link
Member Author

bska commented Jan 21, 2025

jenkins build this only_summary please

@bska bska force-pushed the rst-level-224 branch 12 times, most recently from d66c752 to 89e8ffe Compare January 28, 2025 13:42
@bska bska force-pushed the rst-level-224 branch 8 times, most recently from 7d27083 to 3646044 Compare February 5, 2025 11:53
@bska bska force-pushed the rst-level-224 branch 8 times, most recently from 5e0d4df to 0b6886a Compare February 12, 2025 12:02
@bska bska force-pushed the rst-level-224 branch 6 times, most recently from 1fb59ac to f248258 Compare February 25, 2025 09:31
@bska bska force-pushed the rst-level-224 branch 8 times, most recently from ed607ef to b06460c Compare March 3, 2025 16:41
@bska
Copy link
Member Author

bska commented Mar 6, 2025

jenkins build this only_summary please

@bska bska force-pushed the rst-level-224 branch 10 times, most recently from c32b60a to 39f1fec Compare March 12, 2025 15:41
bska added 3 commits March 13, 2025 09:47
This commit ensures that the setting for whether or not the lift gas
of a leaf node's corresponding group's subordinate wells should be
added to the node's produced gas entering the node in an extended
model production network.  In short, this commit saves and restores
item 4 of NODEPROP for leaf nodes in an extended network.
Needed for compatibility.
Needed for compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant