Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Remove raw pointers for the views in CpGrid #851

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blattms
Copy link
Member

@blattms blattms commented Mar 4, 2025

This pointers were dangling after a grid was copied and the original one removed. Fortunatley, we did not do this in productive code.

This approach uses a boolean to see whether the current view is distributed or not. This way we can use default copy constructors.

Unfortunately. there are a lot of branches now. Let's see what that costs.

This pointers were dangling afte a grid was copied and the original
one removed. Fortunatley, we did not do this in productive code.

This approach uses a boolean to see whether the current view is
distributed or not. This way we can use default copy constructors.

Unfortuantely. there are a lot of branches now. Let's see what that costs.
@blattms
Copy link
Member Author

blattms commented Mar 4, 2025

jenkins build this serial please

@blattms
Copy link
Member Author

blattms commented Mar 5, 2025

benchmark please

@ytelses
Copy link

ytelses commented Mar 8, 2025

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 1.002
opm-git OPM Benchmark: drogon - Threads: 8 0.957
opm-git OPM Benchmark: punqs3 - Threads: 1 0.988
opm-git OPM Benchmark: punqs3 - Threads: 8 0.998
opm-git OPM Benchmark: smeaheia - Threads: 1 0.998
opm-git OPM Benchmark: smeaheia - Threads: 8 1.015
opm-git OPM Benchmark: spe10_model_1 - Threads: 1 0.98
opm-git OPM Benchmark: spe10_model_1 - Threads: 8 0.991
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 0.997
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 1.059
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 1.008
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 1.088
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 - FOPT (Total Oil Production At End Of Run) 1.003
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

View result details @ https://www.ytelses.com/opm/?page=result&id=2708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants