Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual docker scripts #1329
base: release_February_2025
Are you sure you want to change the base?
Individual docker scripts #1329
Changes from all commits
7b7fed8
533317f
293bef8
c0c4102
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary for this PR but I think it would be nice to have a mapping of what environment variables are used in which files, and where they should be defined. It's sometimes difficult to search around the codebase for the definition/default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Consider sanitizing the docker tag for container names.
The web container uses a sanitized variable while core, for example, uses the raw docker tag. If DATAFED_DOCKER_TAG contains unexpected characters, it might cause naming issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use case for having these scripts over using compose and breaking apart services?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Review the method used for quoting volume mount strings.
Assembling the volume mount flags by embedding literal quotes might lead to issues if a mount value contains spaces or special characters. Consider accumulating these in an array and joining them carefully when generating the docker command.
Suggested implementation:
Any subsequent sections of the script that currently reference "local_REPO_VOLUME_MOUNTS_EXPANDED" should be updated to use the new array "local_REPO_VOLUME_MOUNTS_FLAGS". For example, when constructing the docker command, make sure to expand the array using "${local_REPO_VOLUME_MOUNTS_FLAGS[@]}".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Apply consistent sanitization to the docker tag for container naming.
Containers such as the repository container use the raw docker tag. Consistency in sanitizing the tag (as done for the web container) can help avoid potential issues with invalid container names.