Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing hpo packages #218

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Testing hpo packages #218

merged 4 commits into from
Apr 3, 2024

Conversation

allaffa
Copy link
Collaborator

@allaffa allaffa commented Mar 29, 2024

This PR introduces three main examples for hyperparameter optimization (HPO) using the QM9 dataset:

  1. qm9_optuna.py: HPO example using optuna
  2. qm9_deephyper.py: HPO example running in sequential using deephyper
  3. qm9_deephyper_multi.py: HPO example running in parallel using deephyper

@allaffa allaffa requested a review from pzhanggit March 29, 2024 15:33
@allaffa allaffa added the enhancement New feature or request label Mar 29, 2024
@jychoi-hpc
Copy link
Member

Can we save this qm9 as a separate directory (say, qm9_hpo)? We often use qm9 as a minimum case. It would be great if we make "qm9" as simple as possible. How do you think?

@allaffa
Copy link
Collaborator Author

allaffa commented Mar 31, 2024

Can we save this qm9 as a separate directory (say, qm9_hpo)? We often use qm9 as a minimum case. It would be great if we make "qm9" as simple as possible. How do you think?

@jychoi-hpc agree.

@allaffa allaffa force-pushed the testing_hpo_packages branch from e98daff to d814164 Compare March 31, 2024 18:03
Copy link
Member

@jychoi-hpc jychoi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. It looks good to me.

@allaffa allaffa force-pushed the testing_hpo_packages branch from d814164 to 3c75e5e Compare April 1, 2024 18:36
Copy link
Member

@jychoi-hpc jychoi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks.

Copy link
Collaborator

@pzhanggit pzhanggit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me overall. I'll need to learn more about these hpo tools. Three general comments: 1) remove or clean up unused functions in dh_utils.py; 2) save trained models in all trials in qm9.py; 3) maybe add data loaders as command line arguments to avoid repeated data preprocessing in trails.

config["NeuralNetwork"],
log_name,
verbosity,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save_model after training

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added these lines.

@allaffa allaffa requested a review from pzhanggit April 3, 2024 02:52
@allaffa
Copy link
Collaborator Author

allaffa commented Apr 3, 2024

@pzhanggit
I also added num_headlayers and dim_headlayers as hyper-parameters

@allaffa allaffa requested a review from jychoi-hpc April 3, 2024 03:15
Copy link
Member

@jychoi-hpc jychoi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. It looks good to me.

@allaffa allaffa merged commit 0d54eab into ORNL:main Apr 3, 2024
2 checks passed
@allaffa allaffa deleted the testing_hpo_packages branch April 3, 2024 16:05
RylieWeaver pushed a commit to RylieWeaver/HydraGNN that referenced this pull request Oct 17, 2024
* qm9_hpo folder added as separate test

* pei comments addressed

* num_headlayers and dim_headlayers added to hyperparameter list

* black formatting fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants