-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing hpo packages #218
Testing hpo packages #218
Conversation
Can we save this qm9 as a separate directory (say, qm9_hpo)? We often use qm9 as a minimum case. It would be great if we make "qm9" as simple as possible. How do you think? |
@jychoi-hpc agree. |
e98daff
to
d814164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. It looks good to me.
d814164
to
3c75e5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me overall. I'll need to learn more about these hpo tools. Three general comments: 1) remove or clean up unused functions in dh_utils.py
; 2) save trained models in all trials in qm9.py
; 3) maybe add data loaders as command line arguments to avoid repeated data preprocessing in trails.
config["NeuralNetwork"], | ||
log_name, | ||
verbosity, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
save_model
after training
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I added these lines.
@pzhanggit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. It looks good to me.
* qm9_hpo folder added as separate test * pei comments addressed * num_headlayers and dim_headlayers added to hyperparameter list * black formatting fixed
This PR introduces three main examples for hyperparameter optimization (HPO) using the QM9 dataset:
qm9_optuna.py
: HPO example usingoptuna
qm9_deephyper.py
: HPO example running in sequential usingdeephyper
qm9_deephyper_multi.py
: HPO example running in parallel usingdeephyper