Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial implementation of #150 #151

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

initial implementation of #150 #151

wants to merge 5 commits into from

Conversation

superwhiskers
Copy link
Collaborator

@superwhiskers superwhiskers commented Jun 3, 2024 •
edited by pelesh
Loading

this pull request implements the initial suggestions proposed within #150

i'm not going to merge this until some discussion about the formatting options in .clang-format has happened, and appropriate modifications have been made to CONTRIBUTING.md

Closes #54
Closes #150

@superwhiskers superwhiskers requested a review from pelesh June 3, 2024 21:36
@superwhiskers superwhiskers added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels Jun 3, 2024
@superwhiskers superwhiskers self-assigned this Jun 3, 2024
@superwhiskers superwhiskers linked an issue Jun 3, 2024 that may be closed by this pull request
clarify style guidelines in CONTRIBUTING.md / set up clang-format #150
Open
@superwhiskers superwhiskers removed a link to an issue Jun 3, 2024
clarify style guidelines in CONTRIBUTING.md / set up clang-format #150
Open
@pelesh pelesh requested a review from cameronrutherford June 5, 2024 13:58
cameronrutherford
cameronrutherford approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but I approve.

I am not a regex expert so I did not have a chance to verify that those are correct.

@pelesh
Copy link
Collaborator

pelesh commented Jun 11, 2024

Before it is ready for merge, we need to test it on a few representative code snippets to make sure there are no unintended artifacts.

pelesh
pelesh reviewed Jun 11, 2024
View reviewed changes
@cameronrutherford cameronrutherford mentioned this pull request Jun 14, 2024
Merged
4 tasks
@pelesh pelesh mentioned this pull request Sep 20, 2024
Open
@superwhiskers @pelesh
initial implementation of #150, minus adjustments to CONTRIBUTING.md
02f8fa6 
- drop dead code within `CMakeLists.txt`
- remove old `.github/workflows/.clang-format`
- create new `.clang-format` at the repository root, with settings based on observed patterns & `CONTRIBUTING.md`
@superwhiskers @pelesh
use deprecated template declaration breaking option to support clang-…
b96114b 
…format 16 minimum
@superwhiskers @pelesh
integrate suggestions + adjustment to include ordering regex
a5b3e82
@superwhiskers @pelesh
drop integer literal separators
b1f6fa2
@pelesh pelesh force-pushed the implement-initial-suggestions-from-150 branch from 8aff4b8 to b1f6fa2 Compare March 4, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelesh pelesh pelesh left review comments

@cameronrutherford cameronrutherford cameronrutherford approved these changes

Assignees

@stonecoldhughes stonecoldhughes

Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
4 participants
@superwhiskers @pelesh @cameronrutherford @stonecoldhughes