Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting PR template #248

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Correcting PR template #248

merged 3 commits into from
Mar 21, 2025

Conversation

shakedregev
Copy link
Collaborator

Description

Github does not support different PR templates. If more than one template is in the folder, it defaults to the blank template. Github will add support for multiple templates in the future, so we want to keep them, but make sure it recognizes our ReSolve specific (but otherwise generic) template. I also updated this basic template.

Proposed changes

Moved specific PR templates for future use. Updated generic template. This allows Github to recognize the template.

@shakedregev shakedregev self-assigned this Mar 20, 2025
pelesh
pelesh previously requested changes Mar 21, 2025
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR avoids GitHub confusion with multiple PR templates. However, the currently active template is not very helpful. Instead, I would just gently modify bug report template to be a tad more general and use that as the default PR template. I think the checklist we have there would be quite helpful going forward.

@shakedregev shakedregev requested a review from pelesh March 21, 2025 13:21
@shakedregev
Copy link
Collaborator Author

This PR avoids GitHub confusion with multiple PR templates. However, the currently active template is not very helpful. Instead, I would just gently modify bug report template to be a tad more general and use that as the default PR template. I think the checklist we have there would be quite helpful going forward.

@pelesh - sorry about this. I made the change but somehow it didn't save before the push. Should be good now.

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pelesh pelesh merged commit 26df4b2 into develop Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants