P3371R4: Fix rank-{1,2,k,2k} updates #481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Ilya Burylov as coauthor
* Reorganize and expand nonwording sections * Add "`C` may alias `E`" to all the new updating overloads of the symmetric and Hermitian rank-k and rank-2k functions
* Specify that the functions access the new `E` parameter in the same way as the `C` parameter
Add nonwording section explaining why we don't change `triangular_matrix_product`.
* Add nonwording section explaining why we change rank-1 and rank-2 updates to be consistent with rank-k and rank-2k updates. * Revise other nonwording sections accordingly. * Update title and abstract accordingly.
Finish all wording but the rank-2 updates. Revise existing wording.
Add new nonwording discussion of triangular solves (TRSM).
Finish rank-2 update wording.
Thanks to Ilya Burylov and Christian Trott for feedback and suggestions!
1. Remove _`possibly-packed-in-matrix`_, as it is unnecessarily restrictive 2. Fix table formatting 3. Improve nonwording sections more
* Add checklist in revision history * Make sure existing nonwording text doesn't depend on the existence of overloads without a `Scalar alpha` parameter
For R3, add a nonwording section explaining why we remove non-alpha overloads of the symmetric and Hermitian rank-1 and rank-k updates.
For the symmetric and Hermitian rank-1 and rank-k functions, remove overloads that do not have a `Scalar alpha` parameter. Add green and red formatting for the synopsis.
Constrain "linear algebra value type" to be neither `mdspan` nor an execution policy (`is_execution_policy_v<Scalar>` is `false`). This will prevent ambiguous overloads, even if we retain overloads without `Scalar alpha` or add them later.
- [x] Exposition-only concepts - [x] matrix_rank_1_update - [x] matrix_rank_1_update_c
- [x] symmetric_matrix_rank_1_update - [x] hermitian_matrix_rank_1_update
- [x] symmetric_matrix_rank_2_update - [x] hermitian_matrix_rank_2_update
* matrix_rank_1_update wording * matrix_rank_2_update_c wording
Harmonise wording diff with proposed fix for LWG 4137 (atop which this paper is rebased) and add Editorial Notes explaining where the rebase affects this proposal's wording changes.
Also update nonwording section on related proposals and LWG issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.