#186: Avoid multiple saves when handling name and address protection #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds-bellcom
added
the
Incl. in the next release
stankut
requested changes
Oct 8, 2025
| // Only manipulate element on submission create form. | ||
| if (!$webformSubmission->isCompleted()) { | ||
| if ($cprLookupResult && $cprLookupResult->isNameAddressProtected()) { | ||
| // @todo What is this used for? |
There was a problem hiding this comment.
This comes from this requirement in BKDK-550:
https://os2web.atlassian.net/browse/BKDK-550?focusedCommentId=64745
The address field needed to have a hint that it's protected/beskyttet
I see that this key is most likely custom one: #info_message i also don't see any theme using it. For me, it's same to delete this line
If that answers the questions, please remove todo comment from the code 🙂
| else { | ||
| $form['actions']['submit']['#submit'][] = 'os2forms_nemid_submission_set_address_protected'; | ||
| } | ||
|
|
There was a problem hiding this comment.
i could not reproduce the behaviour of a handler being executed twice, but can see that it must be done before the normal submit, otherwise it does not work.
So it's a good change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #186 by ensuring submissions are not saved twice.
Important
This PR is currently aimed at the master branch since the develop branch is many features ahead and a potential patch version should be without these features.