GDALCopyWords64(): tidy code #11254
Merged
GDALCopyWords64(): tidy code #11254
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that no longer accept invalid PRE_BUILD keyword in OUTPUT form of add_custom_command() per https://cmake.org/cmake/help/latest/policy/CMP0175.html Should fix error of https://github.com/OSGeo/gdal/actions/runs/11805369849/job/32887659405?pr=11254
Technically it is safer to cast a pointer to uintptr_t than our custom type. At least, it better documents the intent. In practice, I doubt this changes much.
rouault
force-pushed
the
GDALCopyWords64_tidy
branch
from
98207b4
to
2ce3df2
Compare
|
Looks like nice cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically it is safer to cast a pointer to uintptr_t than our custom type. At least, it better documents the intent. In practice, I doubt this changes much.
CC @schwehr w.r.t #11253 . Very low chance that it fixes your issue