Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI: Add the ProjPicker page to the Location Wizard (Continutation) #1891

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

wxGUI: Add the ProjPicker page to the Location Wizard (Continutation) #1891

wants to merge 69 commits into from

Conversation

ocsmit
Copy link
Contributor

@ocsmit ocsmit commented Sep 26, 2021

This pull request is a continuation of the work of #1770 in addressing #1253 to add a location wizard which is spatially queryable.

The goals/scope of the continuation are

  • Inclusion of toolbar for users. 1
  • Smoother OSM map loading (e.g. lazy loading, separate thread, ...). 2
  • Merge with standard EPSG search wizard. 2

@HuidaeCho Feel free to add anything I missed!

HuidaeCho and others added 30 commits August 2, 2021 06:05
@HuidaeCho
wxGUI: Add the ProjPicker page to the Location Wizard
f2b72b8
@HuidaeCho
Split projpicker into python/grass/projpicker and gui/wxpython/projpi…
37a1c6f 
…cker_gui
@HuidaeCho
Remove repeating reference URLs
275fa31
@HuidaeCho
Fix module name
6d0e223
@HuidaeCho
Try importing projpicker_gui
9eaec96
@HuidaeCho
projpicker.py execute permission off (not meant to be directly run)
8a19fc1
@HuidaeCho
Change to clearer wording
be2c9ee
@HuidaeCho
Change wording at more places
304c16c
@HuidaeCho
Move getosm.py to python/grass/getosm; Leave relative imports only as…
c729c5d 
…suming that none of projpicker modules will be imported from their installation directory
@HuidaeCho
Switch Ctrl for poly; bbox by default
b727b10
@HuidaeCho
Fix drawing poly after pan
c56d425
@HuidaeCho
Type checking only adds CPU time
3f3bfa7
@HuidaeCho
Raise more specific errors
17fbb8e
@HuidaeCho
pyproj.Transformer.from_crs().transform() does not raise an exception…
da1512a 
… by default
@HuidaeCho
No more bare except:
3b41c5d
@HuidaeCho
Apply black to wizard.py
90e9c38
@HuidaeCho
NotImplementedError to ValueError or RuntimeError
e4881a5
@HuidaeCho
Make module-global variables private by prefixing an underscore
2ca331f
@HuidaeCho
Make projpicker importable outside a GRASS session for regenerating p…
56b8886 
…rojpicker.db
@HuidaeCho
argparse is not needed
df1f27f
@HuidaeCho
Add README
0208123
@HuidaeCho
Add back exception handling
f4a2870
@HuidaeCho
Delete ProjPicker-specific code from GUI panel.py; i18n user messages
67c3047
@HuidaeCho
Update gui.py to the latest ProjPicker
2683118
@HuidaeCho
Sync ProjPicker version
75de9f7
@HuidaeCho
Revert single-point bbox handling
f15c9f1
@HuidaeCho
Revert single-point bbox handling
2dce167
@HuidaeCho
Use 1ms delay on macOS
3246a27
@ocsmit
Add wx.WillCall later 1ms delay for MacOS in location wizard
9b1380f
@ocsmit
Black
8055f43
@HuidaeCho HuidaeCho self-assigned this Nov 10, 2023
@HuidaeCho HuidaeCho requested a review from wenzeslaus November 21, 2023 17:32
@wenzeslaus wenzeslaus requested a review from petrasovaa January 8, 2024 15:30
@github-actions github-actions bot added Python Related code is in Python libraries labels Jan 9, 2024
@wenzeslaus wenzeslaus modified the milestones: 8.4.0, Future Apr 27, 2024
@lindakarlovska lindakarlovska mentioned this pull request Oct 15, 2024
Open
@echoix
Copy link
Member

echoix commented Oct 17, 2024

I fixed the conflicts and the simple formatting+ruff issues. There are still some more remaining

@echoix echoix added the conflicts/needs rebase Rebase to or merge with the latest base branch is needed label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus Awaiting requested review from wenzeslaus

@petrasovaa petrasovaa Awaiting requested review from petrasovaa

At least 1 approving review is required to merge this pull request.

Assignees

@HuidaeCho HuidaeCho

Labels
conflicts/needs rebase Rebase to or merge with the latest base branch is needed enhancement New feature or request GUI wxGUI related libraries Python Related code is in Python
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.

[Feat] Map-based UI for easy selection of a projection when creating a new GRASS location
6 participants
@ocsmit @HuidaeCho @nilason @echoix @wenzeslaus @neteler