init: Fix F401 Linter Warnings by Replacing Wildcard Imports with Explicit Imports in __init__.py #4647
+230
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arohanajit
changed the title
This comment has been minimized.
This comment has been minimized.
petrasovaa
reviewed
Nov 5, 2024
petrasovaa
reviewed
Nov 5, 2024
petrasovaa
requested changes
Nov 6, 2024
petrasovaa
requested changes
Nov 11, 2024
petrasovaa
reviewed
Nov 11, 2024
python/grass/script/__init__.py
Outdated
| @@ -1,12 +1,15 @@ | |||
| """Python interface to launch GRASS GIS modules in scripts | |||
| """ | |||
|
|
|||
| from . import setup # noqa: F401 | |||
There was a problem hiding this comment.
This was already there so I didn't change it. I'm assuming for some dependencies since it's not used directly
There was a problem hiding this comment.
It was me like a couple weeks ago. Ruff, in preview mode, didn't do the right suggestion, or had a suggestion loop of some sort. Or maybe the fix was worse with another tool, like pyright, as the file is named setup.py, and it's not a setuptools setup.py file.
So, you might want to try again, it wasn't a big bug that justified the exclusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses multiple
F401linter warnings in the__init__.pyfile by replacing wildcard imports with explicit imports and defining the__all__variable to specify the public API of the module. Replaced Wildcard Imports: Removedfrom .data import *and explicitly imported the necessary functions and classes. Also updated.flake8since noF403warnings were found