Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.in.ogr: Fix Resource Leak issue in proj.c #5303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShubhamDesai
Copy link
Contributor

This pull request fixes issue identified by coverity scan ( CID : 1207667, 1207668, 1415647, 1415695)
Used G_free_key_value() to fix this issue
This pull request refers #5301

@github-actions github-actions bot added vector Related to vector data processing C Related code is in C module labels Mar 5, 2025
@ShubhamDesai
Copy link
Contributor Author

This pull request fixes issue identified by coverity scan ( CID : 1207667, 1207668, 1415647, 1415695) Used G_free_key_value() to fix this issue This pull request refers #5301

@nilason
for this PR you mentioned in #5301 to address proj.h, v.external, r.external in v.in.ogr but i can't find those files in Coverity scan
what filters to apply

@nilason
Copy link
Contributor

nilason commented Mar 19, 2025

This pull request fixes issue identified by coverity scan ( CID : 1207667, 1207668, 1415647, 1415695) Used G_free_key_value() to fix this issue This pull request refers #5301

@nilason for this PR you mentioned in #5301 to address proj.h, v.external, r.external in v.in.ogr but i can't find those files in Coverity scan what filters to apply

The proj.c files are identical, so the same fix should be applied. (For the same reason did Coverity Scan mixed the issues up, and are not shown everywhere.)

@ShubhamDesai
Copy link
Contributor Author

This pull request fixes issue identified by coverity scan ( CID : 1207667, 1207668, 1415647, 1415695) Used G_free_key_value() to fix this issue This pull request refers #5301

@nilason for this PR you mentioned in #5301 to address proj.h, v.external, r.external in v.in.ogr but i can't find those files in Coverity scan what filters to apply

The proj.c files are identical, so the same fix should be applied. (For the same reason did Coverity Scan mixed the issues up, and are not shown everywhere.)

I created PRs for v.external(#5448) and r.external(#5449) but i could not find proj.h in v.in.ogr i think its proj.c which is already addressed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C module vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants