-
-
Notifications
You must be signed in to change notification settings - Fork 377
configure: require GDAL version 3.7+ #6671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- make the version 3.7 the minimal requirement of GDAL support. - remove pre-3.7 specific code
echoix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be noted in a release highlight (for maintainers
at least)
That may well be done (although packagers will probably not be affected by this). If there are no objections, I will shortly merge this PR. |
metzm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have introduced most of these #if GDAL_VERSION_* clauses and I am very happy to see them removed!
Thanks a lot!
Wait till you see the PR for PROJ :) ! |
I guess you will also take care of the old datum transformation options from Proj4 times to convert to WGS84? How about the |
You’re right, |
|
I made significant changes removing HAVE_OGR and HAVE_GDAL (and friends), please take a new good look. |
echoix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave a quick look and read through. Will some similar changes be needed in the addons-repo? (Supporting before and after this PR)
|
Thanks @echoix. I didn't feel good with the handling of |
|
Do we need to switch to ubuntu 24.04 in addons CI? Addons CI fails: |
Yes, I believe we need to. |
At least if we want to run with GRASS core main. |
|
Just for reference: Ubuntu Jammy comes with GRASS 7.8.7 (and GDAL 3.4.1 and PROJ 8.2.1), i.e. very old software. GRASS 8.4 will run on Jammy, but it shouldn’t be the least common denominator. |
Closes #6629