Skip to content

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Nov 28, 2025

  • make the version 3.7 the minimal requirement of GDAL support.
  • remove GDAL pre-3.7 specific code

Closes #6629

- make the version 3.7 the minimal requirement of GDAL support.
- remove pre-3.7 specific code
@nilason nilason added this to the 8.5.0 milestone Nov 28, 2025
@github-actions github-actions bot added vector Related to vector data processing raster Related to raster data processing C Related code is in C libraries module general CMake labels Nov 28, 2025
echoix
echoix previously approved these changes Nov 29, 2025
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be noted in a release highlight (for maintainers
at least)

@nilason
Copy link
Contributor Author

nilason commented Dec 1, 2025

This PR should be noted in a release highlight (for maintainers at least)

That may well be done (although packagers will probably not be affected by this).

If there are no objections, I will shortly merge this PR.

@github-actions github-actions bot added docs markdown Related to markdown, markdown files labels Dec 1, 2025
metzm
metzm previously approved these changes Dec 1, 2025
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have introduced most of these #if GDAL_VERSION_* clauses and I am very happy to see them removed!
Thanks a lot!

@nilason
Copy link
Contributor Author

nilason commented Dec 1, 2025

I think I have introduced most of these #if GDAL_VERSION_* clauses and I am very happy to see them removed! Thanks a lot!

Wait till you see the PR for PROJ :) !

@metzm
Copy link
Contributor

metzm commented Dec 1, 2025

I think I have introduced most of these #if GDAL_VERSION_* clauses and I am very happy to see them removed! Thanks a lot!

Wait till you see the PR for PROJ :) !

I guess you will also take care of the old datum transformation options from Proj4 times to convert to WGS84?

How about the #ifdef HAVE_OGR clauses? GDAL/OGR is now a dependency.

@nilason
Copy link
Contributor Author

nilason commented Dec 1, 2025

How about the #ifdef HAVE_OGR clauses? GDAL/OGR is now a dependency.

You’re right, gdal-config --ogr-enabled has been hardcoded to yes since 2.4.4, and OGR was de facto required part of GDAL longer than that. I’ll clean up that too. Thanks!

@github-actions github-actions bot added windows Microsoft Windows specific database Related to database management raster3d labels Dec 2, 2025
@nilason
Copy link
Contributor Author

nilason commented Dec 2, 2025

I made significant changes removing HAVE_OGR and HAVE_GDAL (and friends), please take a new good look.

echoix
echoix previously approved these changes Dec 2, 2025
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gave a quick look and read through. Will some similar changes be needed in the addons-repo? (Supporting before and after this PR)

@nilason
Copy link
Contributor Author

nilason commented Dec 3, 2025

Thanks @echoix.

I didn't feel good with the handling of GRASS_VECTOR_OGR in v.external{.out}, now I believe to have it right with added commit.

@nilason nilason merged commit 8b4d7c3 into OSGeo:main Dec 4, 2025
25 checks passed
@nilason nilason deleted the fix_gdal_version branch December 4, 2025 08:51
@petrasovaa
Copy link
Contributor

@nilason
Copy link
Contributor Author

nilason commented Dec 4, 2025

Do we need to switch to ubuntu 24.04 in addons CI? https://github.com/OSGeo/grass-addons/blob/grass8/.github/workflows/ci.yml

Addons CI fails: https://github.com/OSGeo/grass-addons/actions/runs/19932951479/job/57149728424

Yes, I believe we need to.

@nilason
Copy link
Contributor Author

nilason commented Dec 4, 2025

Do we need to switch to ubuntu 24.04 in addons CI? https://github.com/OSGeo/grass-addons/blob/grass8/.github/workflows/ci.yml
Addons CI fails: https://github.com/OSGeo/grass-addons/actions/runs/19932951479/job/57149728424

Yes, I believe we need to.

At least if we want to run with GRASS core main.

@nilason
Copy link
Contributor Author

nilason commented Dec 4, 2025

Just for reference: Ubuntu Jammy comes with GRASS 7.8.7 (and GDAL 3.4.1 and PROJ 8.2.1), i.e. very old software. GRASS 8.4 will run on Jammy, but it shouldn’t be the least common denominator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C CMake database Related to database management docs general libraries markdown Related to markdown, markdown files module raster Related to raster data processing raster3d vector Related to vector data processing windows Microsoft Windows specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] Bump required version of GDAL to the GRASS 8.5 release

4 participants