Skip to content

Fix encoding issues #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sebkur
Copy link

@sebkur sebkur commented Apr 4, 2017

I have started working on a GitHub version of JMapProjLib a few years ago and while picking up this work, I realized you have created a more popular fork in the meantime. Instead of working on my own separate version, I would like to participate in the evolution of this project here.

While setting up your project locally, I noticed some files were not properly UTF-8 encoded. Other platforms, including GitHub itself, have problems with this encoding, which is also visible in the rendering of the files and the diffs here on the GitHub website (see the diff of this PR as an example).

Also, four files contained dos-style line-endings, which is discouraged for files checked into Git (if you're working on Windows, git can be configured, also on a per-repository basis, to check in files with the recommended Unix line endings and check out using DOS line-endings on your machine. See
https://help.github.com/articles/dealing-with-line-endings for more information).

Those are the relevant files:

  • src/com/jhlabs/map/GeodeticPosition.java
  • src/com/jhlabs/map/proj/NZMGProjection.java
  • src/com/jhlabs/map/proj/SwissObliqueMercatorProjection.java
  • src/com/jhlabs/map/proj/UniversalTransverseMercatorProjection.java

It would be awesome if you accepted this pull request and try to configure your IDE and git to avoid these problems in the future. Thanks

sebkur added 2 commits April 4, 2017 11:53
Some files contained characters that were not encoded as proper unicode.
Some files contained dos-style CRLF line-endings (and also trailing
whitespace)
@sebkur
Copy link
Author

sebkur commented Apr 4, 2017

I'm working on some improvements in other branches but will wait with pull requests on those because they contain the above commits, too:

@MilesBHuff
Copy link

You should probably just fork this project, at this point. Seems to be abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants