Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started working on a GitHub version of JMapProjLib a few years ago and while picking up this work, I realized you have created a more popular fork in the meantime. Instead of working on my own separate version, I would like to participate in the evolution of this project here.
While setting up your project locally, I noticed some files were not properly UTF-8 encoded. Other platforms, including GitHub itself, have problems with this encoding, which is also visible in the rendering of the files and the diffs here on the GitHub website (see the diff of this PR as an example).
Also, four files contained dos-style line-endings, which is discouraged for files checked into Git (if you're working on Windows, git can be configured, also on a per-repository basis, to check in files with the recommended Unix line endings and check out using DOS line-endings on your machine. See
https://help.github.com/articles/dealing-with-line-endings for more information).
Those are the relevant files:
src/com/jhlabs/map/GeodeticPosition.java
src/com/jhlabs/map/proj/NZMGProjection.java
src/com/jhlabs/map/proj/SwissObliqueMercatorProjection.java
src/com/jhlabs/map/proj/UniversalTransverseMercatorProjection.java
It would be awesome if you accepted this pull request and try to configure your IDE and git to avoid these problems in the future. Thanks