Skip R installation in live parity check workflow - #15
Merged
Conversation
The inspect-r-api job deliberately does not set up R; live-R parity verification is delegated to the parity-autofix workflow (which runs setup-r). The 'Run mapped live R parity' step invoked run_live_r_parity_for_changed_api.py without --skip-install, so the script called install_local_r_nns.py and aborted with "'R' is not on PATH" (exit code 1). Pass --skip-install in the non-fresh-cache path, matching the pattern already used in parity-autofix.yml. The mapped parity tests then gate against the committed cache (CI=true => offline mode), and real live-R verification still runs via the dispatched parity-autofix workflow.
Previously neither CI workflow actually exercised live R: every parity test runs with CI=true, which forces tests/_r.py into offline/cache-only mode, so the gate only replayed the committed cache. parity-autofix even set up R and installed NNS but never called it. Turn parity-autofix into a real fidelity test against the R code that triggered it: - install_local_r_nns.py: add --source (install from a given package source, e.g. the upstream checkout at the recorded commit, instead of the vendored tools/NNS snapshot) and --expected-version (verify the recorded upstream version rather than hard-coding 13.0). - run_live_r_parity_for_changed_api.py: add --live mode. It moves the committed cache aside and runs the mapped parity subset with the offline toggles (CI, NNS_R_CACHE_ONLY, ...) cleared, so every mapped nns() call recomputes against the freshly installed live R and the test asserts Python matches it. The committed cache is always restored unchanged (backup uses the gitignored .json.bak name), so no regenerated values leak into the PR. A failure means real divergence. - parity-autofix.yml: install live R NNS from upstream/NNS at the recorded commit and run the parity step with --live. inspect-r-api stays the fast, R-free detection/cache gate and dispatches parity-autofix, which now performs the live-R fidelity check on any change that maps to parity tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
inspect-r-api-updateworkflow to skip R installation during the live parity verification step, delegating R setup to the downstreamparity-autofixworkflow instead.Changes
--skip-installflag to the live R parity check command when using a cached planparity-autofixworkflow (which is dispatched later) handles R installation and performs the actual live verificationDetails
The workflow now gates mapped parity tests against the committed cache without attempting to install R from local source. This avoids redundant R installation steps and aligns the workflow with the intended division of responsibilities where the
parity-autofixworkflow handles the full R verification pipeline.https://claude.ai/code/session_012bjk4Y5eT1Sva8tNJjqUSw