-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port MASTG-TEST-0006 (by @guardsquare) #3055
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's an explanation potentially missing here
we need to indicate that these attributes can appear as e.g. textPassword
or TYPE_TEXT_VARIATION_PASSWORD
depending on ...
This is sth. I would not have in the theory but rather in the test because it directly affect how we're going to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the explanation in the latest commit. PLease have a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check below, there's some content that could go in a theory chapter and be referenced from the new test. Also the table is good to have as a table in the theory and it indicates the API levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it for now to the test. Please have a look if it's ok.
…rence between them
This PR closes #2936.
TODO: @cpholguera we still need to find a relevant MASWE for it.