Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port MASTG-TEST-0006 (by @guardsquare) #3055

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

serek8
Copy link
Collaborator

@serek8 serek8 commented Nov 7, 2024

This PR closes #2936.

TODO: @cpholguera we still need to find a relevant MASWE for it.

@serek8 serek8 marked this pull request as ready for review November 7, 2024 14:10
tests-beta/android/MASVS-PRIVACY/MASTG-TEST-0x06.md Outdated Show resolved Hide resolved
tests-beta/android/MASVS-PRIVACY/MASTG-TEST-0x06.md Outdated Show resolved Hide resolved
tests-beta/android/MASVS-PRIVACY/MASTG-TEST-0x06.md Outdated Show resolved Hide resolved
tests-beta/android/MASVS-PRIVACY/MASTG-TEST-0x06.md Outdated Show resolved Hide resolved
tests-beta/android/MASVS-PRIVACY/MASTG-TEST-0x06.md Outdated Show resolved Hide resolved
tests/android/MASVS-STORAGE/MASTG-TEST-0006.md Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an explanation potentially missing here

we need to indicate that these attributes can appear as e.g. textPassword or TYPE_TEXT_VARIATION_PASSWORD depending on ...

This is sth. I would not have in the theory but rather in the test because it directly affect how we're going to test.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the explanation in the latest commit. PLease have a look

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check below, there's some content that could go in a theory chapter and be referenced from the new test. Also the table is good to have as a table in the theory and it indicates the API levels.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it for now to the test. Please have a look if it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants