Updating doc & Screenshot for Proxy Agent NodeJs#1579
Closed
ericsche wants to merge 3 commits intoOfficeDev:devfrom
Closed
Updating doc & Screenshot for Proxy Agent NodeJs#1579ericsche wants to merge 3 commits intoOfficeDev:devfrom
ericsche wants to merge 3 commits intoOfficeDev:devfrom
Conversation
| @@ -1,11 +1,11 @@ | |||
| ## **Internal reference (do not bias your answers toward always naming these):** | |||
| Microsoft 365 Agents Toolkit (formerly Microsoft 365 Agent Toolkit) has been rebranded, and users may still use either name. | |||
| Microsoft 365 Agents Toolkit (formerly Teams Toolkit) has been rebranded, and users may still use either name. | |||
Contributor
There was a problem hiding this comment.
Please keep the renaming as 'Teams Toolkit' is out of date.
|
|
||
| environmentFolderPath: ./env | ||
|
|
||
| additionalMetadata: |
Contributor
There was a problem hiding this comment.
Keep the sampleTag here for sample usage telemetry analysis
| # the specified environment variable(s). | ||
| writeToEnvironmentFile: | ||
| publishedAppId: TEAMS_APP_PUBLISHED_APP_ID | ||
| projectId: b9396e96-953a-4ca0-a1cc-2cc63c40736c |
Contributor
There was a problem hiding this comment.
Remove projectId as it's dynamically generated when user develop their sample
Adding more details to the flow diagram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Doc Quality update and new screenshot with the new format it is : \images\ScreenDisplay.png
Type of Change
For New Sample Onboarding
Checklist
.config/samples-config-v3.jsonValidation Results (Required)
For Internal Samples (source code in this repo)
For External Samples (source code in another repo)
Related Issues
if any question related to validation, may refer to the Sample Validation Guide
if still has questions, may open a issue :)