Skip to content

Updating doc & Screenshot for Proxy Agent NodeJs#1579

Closed
ericsche wants to merge 3 commits intoOfficeDev:devfrom
ericsche:ericsche-ProxyAgent-NodeJS
Closed

Updating doc & Screenshot for Proxy Agent NodeJs#1579
ericsche wants to merge 3 commits intoOfficeDev:devfrom
ericsche:ericsche-ProxyAgent-NodeJS

Conversation

@ericsche
Copy link
Copy Markdown
Contributor

Pull Request

Description

Doc Quality update and new screenshot with the new format it is : \images\ScreenDisplay.png

Type of Change

  • New sample onboarding (internal - source code in this repo)
  • New sample onboarding (external - source code in another repo)
  • Sample update/fix
  • Documentation update
  • Validation tool update
  • Other (please describe)

For New Sample Onboarding

Checklist

  • I have added/updated the sample entry in .config/samples-config-v3.json
  • I have included a README.md with setup instructions
  • I have included a thumbnail image with correct aspect ratio (40:23, e.g., 1600×920 or 800×460)

Validation Results (Required)

Important: You must run the validation tool locally and provide a screenshot of the results.

For Internal Samples (source code in this repo)

cd validation-tool
npm install
node validator.cjs -p ../<your-sample-folder>

For External Samples (source code in another repo)

cd validation-tool
npm install

# Clone your sample repo (sparse checkout recommended)
git clone --filter=blob:none --sparse <your-repo-url>
cd <repo-name>
git sparse-checkout set <path-to-sample>
cd ..

# Run validation
node validate-external.js <sample-id> ./<repo-name>

Related Issues

if any question related to validation, may refer to the Sample Validation Guide
if still has questions, may open a issue :)

@@ -1,11 +1,11 @@
## **Internal reference (do not bias your answers toward always naming these):**
Microsoft 365 Agents Toolkit (formerly Microsoft 365 Agent Toolkit) has been rebranded, and users may still use either name.
Microsoft 365 Agents Toolkit (formerly Teams Toolkit) has been rebranded, and users may still use either name.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the renaming as 'Teams Toolkit' is out of date.


environmentFolderPath: ./env

additionalMetadata:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the sampleTag here for sample usage telemetry analysis

Comment thread ProxyAgent-NodeJS/m365agents.yml Outdated
# the specified environment variable(s).
writeToEnvironmentFile:
publishedAppId: TEAMS_APP_PUBLISHED_APP_ID
projectId: b9396e96-953a-4ca0-a1cc-2cc63c40736c
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove projectId as it's dynamically generated when user develop their sample

@ericsche ericsche closed this Jan 29, 2026
@ericsche ericsche deleted the ericsche-ProxyAgent-NodeJS branch January 29, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants