QA: openFieldDetail tutarlılığı + role-span robustluğu + test kapsamı (+15)#42
Merged
Conversation
- fields.js openFieldDetail: scrollTo(0,0) + focus preventScroll:true + mobil sidebar kapatma (navigate() ile tutarlı; tarla detayı artık tepeden açılır) - account.js _applyRoleVisibility: .user-badge-role HARİÇ (o span data-role'ü yalnız CSS renk kodu için taşır, gating'e girmemeli) + birim test için export Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- charts_retheme.test.js (4): rethemeCharts renk güncelleme + amber/mavi accent korunması + grid-kapalı eksen - account_rolevis.test.js (5): rol-gating (admin/çiftçi/developer/null) + .user-badge-role hariç - router_nav.test.js (6): sayfa aktivasyon + hash senkron (replaceState) + scrollTo(0,0) + nav-item active + sidebar + handler Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Özet
nav-rol-gorunurluk (#41) sonrası yürütülen aykırılık denetimi + test koşumundan çıkan düzeltmeler. 13 aykırılık tespit → 10 onaylandı; gerçek bug'lar + test kapsamı boşlukları burada kapatıldı.
fix (07d4c9c)
navigate()ile tutarlı:scrollTo(0,0)+focus preventScroll:true+ mobil sidebar kapatma → tarla detayı artık tepeden açılır (Nav rol görünürlüğü + navigasyon/refresh + tema-grafik düzeltmeleri #41'deki fix bu yola da uygulandı)_applyRoleVisibility(account.js):.user-badge-rolespan'i gating'den hariç tutuldu (o span data-role'ü yalnız CSS renk kodu için taşır) — kırılganlık giderildi; birim test için exporttest (cd56d17) — +15 vitest
charts_retheme.test.js(4): rethemeCharts renk güncelleme + amber/mavi accent korunması + grid-kapalı eksenaccount_rolevis.test.js(5): rol-gating (admin/çiftçi/developer/null) + .user-badge-role hariçrouter_nav.test.js(6): sayfa aktivasyon + hash senkron (replaceState) + scrollTo(0,0) + nav-item active + sidebar + handlerTest
🤖 Generated with Claude Code