fix(welcome): inline tema script'ini harici dosyaya al (CI düzeltmesi)#45
Merged
Conversation
…I düzeltmesi) - welcome'ın head'deki inline anti-FOUC tema script'i TestAssetSplit:: test_no_inline_script_block'u kırıyordu (proje kuralı: inline <script> yok — asset-split/CSP) - script → frontend/src/theme-init.js (harici + render-blocking KLASİK script); index.html'de inline blok → <script src="src/theme-init.js"> - type=module DEĞİL → boyamadan önce çalışır → FOUC önleme korundu (davranış birebir) - doğrulandı: test_frontend_a11y.py 34/34 passed; gündüz/gece runtime'da doğru, flash yok Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorun
PR #44 (welcome) merge'ünden sonra SFDAP CI Pipeline kırmızı oldu:
tests/test_frontend_a11y.py::TestAssetSplit::test_no_inline_script_blockfail.Welcome'ın
<head>'ine eklenen inline anti-FOUC tema script'i, projenin"inline
<script>yok" (asset-split / CSP) kuralını ihlal ediyordu. Coverage iyiydi(%94.9); fail eden tek test buydu (A11y + Security job'ları geçti).
Çözüm
Testi gevşetmek yerine standarda uyduk: tema script'i
frontend/src/theme-init.js'e taşındı.type=moduledeğil) → boyamadan önce çalışır → FOUC önleme korunduindex.html: inline blok →<script src="src/theme-init.js"></script>Doğrulama
tests/test_frontend_a11y.py→ 34/34 passed (kırılan test dahil, regresyon yok)data-theme="light"boyamadan önce yazılıyor)