Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Bing maps content script to have app namespace and Google codestyle #46

Merged
merged 9 commits into from
Mar 30, 2016

Conversation

heychirag
Copy link
Collaborator

Hello @ceilican

I am preparing my proposal for GSoC 16, which I'll submit soon. For demonstration purposes I am submitting a PR related to issue #10

Since reviewing this issue in it's entirety, in a single PR would be unfair to you. I will be sending multiple PRs resolving a small chunk at a time.

This PR changes the following file(s):

  1. Source/BingMapsCarbonFootprint.js

In this PR:

  • Added app namespace so that we do not interfere with other JS variables on page.
  • Follow Google's JS guide.
  • Zero Errors by Google JS linter 'gjslint'.
  • Minor refactoring of some methods.

Thanks
PS: Sorry about the noise on this PR, still getting used what GIT is all about. Will send out remaining changes in a different PR.

@heychirag heychirag changed the title Google codestyle Google codestyle and Improved Form Validation Mar 23, 2016
@heychirag heychirag changed the title Google codestyle and Improved Form Validation Improving Bing maps content script to have app namespace and Google codestyle Mar 24, 2016
@ceilican ceilican merged commit 870a9e4 into OiWorld:master Mar 30, 2016
@ceilican
Copy link
Contributor

Thanks!!

@heychirag heychirag deleted the google-codestyle branch March 30, 2016 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants