Fixed public transport CO2 emission #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @heychirag ! Yes, I think it is ok now! Just one thing: your PR is failing on one test (https://travis-ci.org/OiWorld/CarbonFootprintGoogleMaps/builds/149279129). Could you find out why and fix your PR or the tests? As soon as the PR passes all tests, I will merge it. |
|
Hi @ceilican, I have fixed the bug. Now driving i.e. 'd' will be considered as the default type if not passed to the function. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ceilican,
I have removed the need for passing 'type' as an extra argument. However, it is still being used for calling functions in same namespace. As of different namespaces, I have created a different function for each. Let me know if you like this approach. If this is okay, I will add an option in the options page to let the user configure the number of passengers in a bus.
The Best