Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the remaining batch of *.fnl files #603

Merged
merged 14 commits into from
Sep 6, 2024

Conversation

russtoku
Copy link
Contributor

@russtoku russtoku commented Sep 3, 2024

Converted clients and related modules (not tested):

  • Guile
  • Janet
  • Rust

Converted Clojure client-related files (somewhat tested by running Clojure client agains dev/clojure/sandbox.cljc):

  • action.fnl
  • auto-repl.fnl
  • debugger.fnl
  • init.fnl
  • parse.fnl
  • server.fnl
  • state.fnl
  • ui.fnl

Converted remaining legacy tests.

@Olical Olical merged commit 6782532 into Olical:nfnl-migration Sep 6, 2024
3 checks passed
@Olical
Copy link
Owner

Olical commented Sep 6, 2024

Looks perfect! Removed a couple more *module* references too. I think I'll give this a bit of smoke testing, rename the branch to main then create a discussion post explaining the migration and encourage those who can to move over to it and report back in with issues or a 👍🏼 if things are okay for them.

Thank you so much for all of the work you've done on this, it's been amazing! You've pushed this boulder up and over the top of the mountain that I kept putting off. Once this is stable we can make so many changes so much easier with LSP support and a much lower barrier to entry.

@russtoku russtoku deleted the nfnl-migration branch September 6, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants