-
Notifications
You must be signed in to change notification settings - Fork 0
AFD: update DeepSeek support #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: afd-step3
Are you sure you want to change the base?
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
@Oliver-ss could you spend some time reviewing the code? the follow-up features will be updated with independent PRs |
…ect#26445) Signed-off-by: Nick Hill <[email protected]>
|
There seems to be some inconsistency in understanding. According to the content of the paper, the number of attention instances has no correlation with the TP parallel scale, and your configuration here should be 1A1F. |
| group_name="afd", | ||
| timeout=timedelta(minutes=2), | ||
| ) | ||
| ffn_ranks = [i for i in range(ffn_size, ffn_size + attn_size)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be range(attn_size, ffn_size + attn_size)
| hidden_states, residual = self.post_attention_layernorm( | ||
| hidden_states, residual) | ||
| # ---------ascend ffn need data | ||
| if forward_ctx.moe_comm_method_name is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, where is this moe_comm_method_name field defined for ForwardContext?
Purpose
This PR corresponds to the RFC vllm-project#22799 and a follow-up PR of vllm-project#25162.
This PR is in collaboration with @chopper0126 @CZRZ
Later, we are going to support the following features:
Test Plan
At this stage, we used 4 GTX3090 GPUs to test the feasibility of our implementation. Both attention and FFN sides shard across 2 GPUs.
Test Result
By sending a request to the model, we got:

Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.