Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: BLV and Metric Improvements #2909

Merged
merged 24 commits into from
Jul 27, 2023
Merged

Dashboard: BLV and Metric Improvements #2909

merged 24 commits into from
Jul 27, 2023

Conversation

0xJem
Copy link
Contributor

@0xJem 0xJem commented Jul 20, 2023 •
edited
Loading

  • Mirrors changes to BLV categorisation from BLV and Metric Improvements treasury-subgraph#38
  • Update treasury-subgraph-client version
  • Shift to using metrics calculated in treasury-subgraph, instead of calculating them locally (which duplicates code to maintain)
  • Remove dead code

@0xJem 0xJem self-assigned this Jul 20, 2023
@socket-security
Copy link

socket-security bot commented Jul 20, 2023 •
edited
Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@wundergraph/react-query 0.8.46...0.8.50 None +26/-77 43.8 MB jens-wundergraph

🚮 Removed packages: @olympusdao/[email protected], @wundergraph/[email protected]

@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
77.84% (+0.23% 🔼)
 43085/55351
🟡 Branches
79.74% (+0.29% 🔼)
 1354/1698
🔴 Functions
47.89% (+1.73% 🔼)
 635/1326
🟡 Lines
77.84% (+0.23% 🔼)
 43085/55351
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / TreasuryQueryHelper.ts
25% (-26.89% 🔻)
 100% 0%
25% (-26.89% 🔻)
🔴
... / useFederatedSubgraphQuery.ts
47.14% (-10.66% 🔻)
 66.67%
10.53% (-31.58% 🔻)
47.14% (-10.66% 🔻)
🔴
... / useTokenSupplyMetrics.ts
12.82% (-6.28% 🔻)
 100% 0%
12.82% (-6.28% 🔻)
🔴
... / useTreasuryMetrics.ts
25.56% (-1.11% 🔻)
 100% 0%
25.56% (-1.11% 🔻)
🟢
... / BondModal.tsx
 95.91%
84% (-1.19% 🔻)
 40% 95.91%
🔴
... / DataWarning.tsx
14.81% (-1.53% 🔻)
 100% 0%
14.81% (-1.53% 🔻)
🟢
... / Constants.ts
98.04% (-0.07% 🔻)
 100% 0%
98.04% (-0.07% 🔻)
🔴
... / LiquidBackingComparisonGraph.tsx
13.64% (-4.25% 🔻)
 100% 0%
13.64% (-4.25% 🔻)
🔴
... / OhmSupplyGraph.tsx
14.12% (-7.77% 🔻)
 100% 0%
14.12% (-7.77% 🔻)
🔴
... / OhmSupplyTable.tsx
14.18% (-3.69% 🔻)
 100% 0%
14.18% (-3.69% 🔻)

Test suite run success

185 tests passing in 115 suites.

Report generated by 🧪jest coverage report action from 1402567

0xJem added 19 commits July 25, 2023 15:35
@0xJem
Keep wundergraph SDK version consistent with treasury-subgraph-client
9405860
@0xJem
Sync circulating and floating supply definitions with treasury-subgraph
b8ab24d 
OlympusDAO/treasury-subgraph#38
@0xJem
Remove console log
83e4e03
@0xJem
Re-generate lockfile
159f0c6
@0xJem
Remove duplicate dependency (imported through treasury-subgraph-client)
3719d8a
@0xJem
Bump wundergraph and treasury-subgraph-client dependencies
27a0759
@0xJem
Shift from use of protocolMetrics query (now internal) to metrics query
0b822ee
@0xJem
WIP shifting to metrics from treasury-subgraph
f086ef5
@0xJem
TODOs
82a7d3c
@0xJem
Incorrect query parameter
30e0738
@0xJem
Shift OHM supply graph to use the API metrics
1f7c8e8
@0xJem
Updated enum values for supply categories
1b4b9c6
@0xJem
Shift OHM supply table to use API metrics
72d8092
@0xJem
Shift remaining functions to use metrics/simplified hooks
61617d4
@0xJem
Cleanup
006b0de
@0xJem
Add ts-prune to find dead code
629c072
@0xJem
Remove unused code
30c002c
@0xJem
Correct definition for liquid backing per gOHM. Remove dead code.
ac4d904
@0xJem
Correct description
e0a966f
@0xJem 0xJem changed the title Update categorisation of BLV Dashboard: BLV and Metric Improvements Jul 25, 2023
@0xJem 0xJem marked this pull request as ready for review July 25, 2023 12:56
@0xJem 0xJem requested a review from appleseed-iii July 25, 2023 12:58
@0xJem
Copy link
Contributor Author

0xJem commented Jul 25, 2023

This is reliant on the treasury-subgraph changes to be live. It is building now. Will update when it's live (and tested against the current frontend).

@0xJem
Copy link
Contributor Author

0xJem commented Jul 25, 2023

Production API deployment done.
Confirmed that the Fleek preview build works against the production API.

appleseed-iii
appleseed-iii approved these changes Jul 27, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@appleseed-iii appleseed-iii merged commit 3296451 into develop Jul 27, 2023
5 checks passed
@appleseed-iii appleseed-iii deleted the dashboard-metrics branch July 27, 2023 17:07
appleseed-iii added a commit that referenced this pull request Aug 7, 2023
@appleseed-iii @0xJem
Dashboard: BLV and Metric Improvements (#2909) (#2915)
59c9d48 
* Keep wundergraph SDK version consistent with treasury-subgraph-client

* Sync circulating and floating supply definitions with treasury-subgraph

OlympusDAO/treasury-subgraph#38

* Remove console log

* Re-generate lockfile

* Remove duplicate dependency (imported through treasury-subgraph-client)

* Bump wundergraph and treasury-subgraph-client dependencies

* Shift from use of protocolMetrics query (now internal) to metrics query

* WIP shifting to metrics from treasury-subgraph

* TODOs

* Incorrect query parameter

* Shift OHM supply graph to use the API metrics

* Updated enum values for supply categories

* Shift OHM supply table to use API metrics

* Shift remaining functions to use metrics/simplified hooks

* Cleanup

* Add ts-prune to find dead code

* Remove unused code

* Correct definition for liquid backing per gOHM. Remove dead code.

* Correct description

* Bump treasury-subgraph-client version

* Fix date displays

* Fix missing key error

* Fix error with Skeleton component

* remove ts-prune

---------

Co-authored-by: Jem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleseed-iii appleseed-iii appleseed-iii approved these changes

Assignees

@0xJem 0xJem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xJem @appleseed-iii