Skip to content

Delete Subscription by Type #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: identity_verification_beta
Choose a base branch
from

Conversation

fadi-george
Copy link
Contributor

@fadi-george fadi-george commented Jun 18, 2025

Description

One Line Summary

OneSignal Identity Verification feature only exists today for the Player model and we want to bring this feature to the User Model.

Details

  • Update deleteSubscription call to pass in a subscription type and a token/address.
  • Encodes subscription token/address when making a call to delete the subscription
  • Updates DeleteSubscriptionOperation class to have new fields like type (subscription type) and address (subscription token)
  • Added test cases for SubscriptionBackendService and fixed other tests involving deleteSubscription

Motivation

There is a new api to delete subscription deletion by type where you can also pass in a JWT.

Scope

Now allows JWT to be used to delete a subscription.

Testing

Unit testing

Updates calls.

Manual testing

TBD - API Route is returning 404.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

Cannot yet test due to api route not existing?

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george requested review from jinliu9508 and nan-li and removed request for jinliu9508 June 18, 2025 21:18
@fadi-george fadi-george force-pushed the feat-delete-subscription-by-type branch from 402bee9 to 45956d8 Compare June 18, 2025 21:27
@fadi-george fadi-george force-pushed the feat-delete-subscription-by-type branch from b5f61f5 to 6df670e Compare June 18, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants