Skip to content

Fix security vuln#621

Merged
soumeh01 merged 2 commits into
mainfrom
fix-vuln
May 19, 2026
Merged

Fix security vuln#621
soumeh01 merged 2 commits into
mainfrom
fix-vuln

Conversation

@soumeh01

@soumeh01 soumeh01 commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 11 package(s) with unknown licenses.
See the Details below.

Snapshot Warnings

⚠️: The number of snapshots compared for the base SHA (0) and the head SHA (1) do not match. You may see unexpected additions in the diff.
Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice.

License Issues

go.mod

PackageVersionLicenseIssue Type
github.com/creack/ptyv1.1.24NullUnknown License
github.com/davecgh/go-spewv1.1.1NullUnknown License
github.com/hashicorp/go-versionv1.9.0NullUnknown License
github.com/otiai10/copyv1.14.1NullUnknown License
github.com/pmezard/go-difflibv1.0.0NullUnknown License
github.com/sirupsen/logrusv1.9.4NullUnknown License
github.com/spf13/cobrav1.10.2NullUnknown License
github.com/spf13/pflagv1.0.10NullUnknown License
github.com/stretchr/testifyv1.11.1NullUnknown License
golang.org/x/termv0.43.0NullUnknown License
gopkg.in/yaml.v3v3.0.1NullUnknown License

OpenSSF Scorecard

Scorecard details
PackageVersionScoreDetails
gomod/github.com/aymanbagabas/go-pty v0.2.3 🟢 3.8
Details
CheckScoreReason
Code-Review🟢 3Found 1/3 approved changesets -- score normalized to 3
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Maintained🟢 79 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 7
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Packaging⚠️ -1packaging workflow not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
gomod/github.com/creack/pty v1.1.24 UnknownUnknown
gomod/github.com/davecgh/go-spew v1.1.1 UnknownUnknown
gomod/github.com/hashicorp/go-version v1.9.0 UnknownUnknown
gomod/github.com/otiai10/copy v1.14.1 UnknownUnknown
gomod/github.com/pmezard/go-difflib v1.0.0 UnknownUnknown
gomod/github.com/sirupsen/logrus v1.9.4 UnknownUnknown
gomod/github.com/spf13/cobra v1.10.2 UnknownUnknown
gomod/github.com/spf13/pflag v1.0.10 UnknownUnknown
gomod/github.com/stretchr/testify v1.11.1 UnknownUnknown
gomod/github.com/u-root/u-root v0.16.0 🟢 7.4
Details
CheckScoreReason
Security-Policy🟢 4security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Code-Review🟢 10all changesets reviewed
Maintained🟢 1030 commit(s) and 4 issue activity found in the last 90 days -- score normalized to 10
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 2badge detected: InProgress
Fuzzing🟢 10project is fuzzed
Binary-Artifacts🟢 9binaries present in source code
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Packaging🟢 10packaging workflow detected
SAST🟢 10SAST tool is run on all commits
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
gomod/golang.org/x/crypto v0.51.0 UnknownUnknown
gomod/golang.org/x/sync v0.18.0 UnknownUnknown
gomod/golang.org/x/sys v0.44.0 UnknownUnknown
gomod/golang.org/x/term v0.43.0 UnknownUnknown
gomod/gopkg.in/yaml.v3 v3.0.1 UnknownUnknown

Scanned Files

  • .github/workflows/global.yaml
  • go.mod

@qltysh

qltysh Bot commented May 19, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

    6 files  ±0     60 suites  ±0   11s ⏱️ -1s
  307 tests ±0    307 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 842 runs  ±0  1 842 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b5f195. ± Comparison against base commit fa71714.

@soumeh01 soumeh01 marked this pull request as ready for review May 19, 2026 11:39
Copilot AI review requested due to automatic review settings May 19, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflows to address security/code-scanning findings by tightening how third-party tooling is installed during CI checks.

Changes:

  • Switches the TPIP workflow to install go-licenses from the v2 module path.
  • Pins pre-commit and comment-parser to exact versions in the global workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/tpip-check.yml Updates the go-licenses installation source used for TPIP reporting/checks.
.github/workflows/global.yaml Pins Python tooling versions used by the copyright notice check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/tpip-check.yml Outdated
Comment thread .github/workflows/tpip-check.yml Outdated
Comment thread .github/workflows/global.yml Outdated
Copilot AI review requested due to automatic review settings May 19, 2026 12:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/tpip-check.yml Outdated
Copilot AI review requested due to automatic review settings May 19, 2026 12:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/tpip-check.yml
@soumeh01 soumeh01 requested a review from brondani May 19, 2026 14:15
@soumeh01 soumeh01 merged commit 705e1db into main May 19, 2026
5 checks passed
@soumeh01 soumeh01 deleted the fix-vuln branch May 19, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants