Skip to content

[projmgr] Update test case OutputDirsAbsolutePath#2083

Merged
brondani merged 3 commits into
mainfrom
projmgr-check-testcase
May 15, 2025
Merged

[projmgr] Update test case OutputDirsAbsolutePath#2083
brondani merged 3 commits into
mainfrom
projmgr-check-testcase

Conversation

@brondani

@brondani brondani commented May 14, 2025

Copy link
Copy Markdown
Collaborator

The test case OutputDirsAbsolutePath is intended to catch a non-portable absolute path on Windows.
GH Runners for win-amd64 started to use the C: drive letter instead of D:, hiding the portability issue under test and causing the test failure.
This PR sets an UNC path \\non_existing_cmsis in the non-portable absolute path under test, restoring the expected test behavior.

Comment thread tools/projmgr/test/src/ProjMgrUnitTests.cpp Fixed
Comment thread tools/projmgr/test/src/ProjMgrUnitTests.cpp Fixed
@brondani brondani force-pushed the projmgr-check-testcase branch 3 times, most recently from c1572aa to 301ba4d Compare May 15, 2025 08:04
@brondani brondani force-pushed the projmgr-check-testcase branch from 301ba4d to 9789f07 Compare May 15, 2025 09:43
@github-actions

github-actions Bot commented May 15, 2025

Copy link
Copy Markdown

Test Results

    3 files     18 suites   12m 6s ⏱️
  389 tests   389 ✅ 0 💤 0 ❌
1 167 runs  1 167 ✅ 0 💤 0 ❌

Results for commit 0001e52.

♻️ This comment has been updated with latest results.

@brondani brondani marked this pull request as ready for review May 15, 2025 09:58
@brondani brondani requested a review from soumeh01 May 15, 2025 09:58
@brondani brondani changed the title [projmgr] Test OutputDirsAbsolutePath [projmgr] Update test case OutputDirsAbsolutePath May 15, 2025
@brondani brondani requested a review from edriouk May 15, 2025 13:21

@edriouk edriouk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@brondani brondani merged commit 043b2f1 into main May 15, 2025
32 of 33 checks passed
@brondani brondani deleted the projmgr-check-testcase branch May 15, 2025 15:07
@codecov

codecov Bot commented May 15, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.36%. Comparing base (3f8f03a) to head (0001e52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrUnitTests.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
- Coverage   66.36%   66.36%   -0.01%     
==========================================
  Files         173      173              
  Lines       36461    36461              
  Branches    21225    21225              
==========================================
- Hits        24198    24197       -1     
  Misses       7878     7878              
- Partials     4385     4386       +1     
Flag Coverage Δ
projmgr-cov 81.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/test/src/ProjMgrUnitTests.cpp 80.36% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants