[csolution-rpc] Handle content-length header CRLF line endings for LSP compliance#2122
Merged
brondani merged 1 commit intoJun 27, 2025
Conversation
Test Results 33 files 66 suites 9s ⏱️ Results for commit 248e788. ♻️ This comment has been updated with latest results. |
brondani
approved these changes
Jun 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
==========================================
+ Coverage 65.74% 65.79% +0.04%
==========================================
Files 181 181
Lines 37039 37067 +28
Branches 21533 21553 +20
==========================================
+ Hits 24352 24388 +36
+ Misses 8273 8261 -12
- Partials 4414 4418 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compliant to https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#baseProtocol
Add
CrossPlatformUtils::Crlf(): overcomes the automatic translation from\ninto\r\nwhen usingstd::couton Windows.