Skip to content

[csolution-rpc] Handle content-length header CRLF line endings for LSP compliance#2122

Merged
brondani merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/csolution-rpc-accept-line-endings
Jun 27, 2025
Merged

[csolution-rpc] Handle content-length header CRLF line endings for LSP compliance#2122
brondani merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/csolution-rpc-accept-line-endings

Conversation

@grasci-arm

@grasci-arm grasci-arm commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

Compliant to https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#baseProtocol

Add CrossPlatformUtils::Crlf(): overcomes the automatic translation from \n into \r\n when using std::cout on Windows.

@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown

Test Results

 33 files   66 suites   9s ⏱️
164 tests 164 ✅ 0 💤 0 ❌
492 runs  492 ✅ 0 💤 0 ❌

Results for commit 248e788.

♻️ This comment has been updated with latest results.

@brondani brondani merged commit a4e7267 into Open-CMSIS-Pack:main Jun 27, 2025
106 of 109 checks passed
@brondani brondani deleted the outbound/csolution-rpc-accept-line-endings branch June 27, 2025 07:35
@codecov

codecov Bot commented Jun 27, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.79%. Comparing base (eda99da) to head (248e788).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrRpcTests.cpp 84.00% 0 Missing and 4 partials ⚠️
tools/projmgr/src/ProjMgrRpcServer.cpp 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2122      +/-   ##
==========================================
+ Coverage   65.74%   65.79%   +0.04%     
==========================================
  Files         181      181              
  Lines       37039    37067      +28     
  Branches    21533    21553      +20     
==========================================
+ Hits        24352    24388      +36     
+ Misses       8273     8261      -12     
- Partials     4414     4418       +4     
Flag Coverage Δ
buildmgr-cov 73.95% <ø> (ø)
packgen-cov 77.87% <ø> (ø)
projmgr-cov 80.05% <80.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrRpcServer.h 75.00% <ø> (ø)
tools/projmgr/src/ProjMgrRpcServer.cpp 29.76% <60.00%> (+5.66%) ⬆️
tools/projmgr/test/src/ProjMgrRpcTests.cpp 82.43% <84.00%> (+0.79%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants