Refactor csolution process components (#1258)#2137
Merged
brondani merged 2 commits intoJul 8, 2025
Merged
Conversation
* Refactor csolution process components Enhance RteComponentInstance with GetComponent() always create RteComponentInstance * Refactor csolution process components always create RteComponentInstance, even for missing component keep unresolved RteComponentInstance in rpc mode and insert it into RTE model
edriouk
previously approved these changes
Jul 8, 2025
Test Results 7 files 53 suites 4m 52s ⏱️ Results for commit eae36ed. ♻️ This comment has been updated with latest results. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
NULL pointer check
brondani
approved these changes
Jul 8, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2137 +/- ##
==========================================
+ Coverage 66.03% 66.09% +0.06%
==========================================
Files 181 181
Lines 37243 37306 +63
Branches 21670 21701 +31
==========================================
+ Hits 24592 24656 +64
+ Misses 8203 8198 -5
- Partials 4448 4452 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance RteComponentInstance with GetComponent()
always create RteComponentInstance
always create RteComponentInstance, even for missing component
keep unresolved RteComponentInstance in rpc mode and insert it into RTE model