Skip to content

Rpc protocol enhancements#2145

Merged
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/rpcProtocolEnhancements
Jul 15, 2025
Merged

Rpc protocol enhancements#2145
edriouk merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/rpcProtocolEnhancements

Conversation

@grasci-arm

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Jul 14, 2025

Copy link
Copy Markdown

Test Results

  7 files   53 suites   5m 17s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 7720216.

♻️ This comment has been updated with latest results.

Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Dismissed
context
};
auto requests = CreateLoadRequests("/Validation/dependencies.csolution.yml", contextList);
int id = 3;

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable id is not used.
Comment thread tools/projmgr/test/src/ProjMgrRpcTests.cpp Dismissed
param["variant"] = "Compatible";

auto requests = CreateLoadRequests("/Validation/dependencies.csolution.yml", contextList);
int id = 3;

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable id is not used.
Comment thread tools/projmgr/test/src/ProjMgrRpcTests.cpp Dismissed
@brondani brondani requested a review from edriouk July 14, 2025 18:19
@edriouk edriouk merged commit 097316d into Open-CMSIS-Pack:main Jul 15, 2025
83 of 84 checks passed
@edriouk edriouk deleted the outbound/rpcProtocolEnhancements branch July 15, 2025 06:28
@codecov

codecov Bot commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 68.52459% with 96 lines in your changes missing coverage. Please review.

Project coverage is 66.55%. Comparing base (4f02c45) to head (7720216).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrRpcTests.cpp 63.19% 0 Missing and 60 partials ⚠️
tools/projmgr/src/ProjMgrRpcServerData.cpp 65.45% 8 Missing and 11 partials ⚠️
tools/projmgr/src/ProjMgrRpcServer.cpp 80.76% 11 Missing and 4 partials ⚠️
tools/projmgr/src/ProjMgrWorker.cpp 87.50% 0 Missing and 1 partial ⚠️
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
+ Coverage   66.10%   66.55%   +0.45%     
==========================================
  Files         181      181              
  Lines       37326    37567     +241     
  Branches    21711    21888     +177     
==========================================
+ Hits        24675    25004     +329     
+ Misses       8202     8033     -169     
- Partials     4449     4530      +81     
Flag Coverage Δ
buildmgr-cov 73.95% <ø> (ø)
packchk-cov 70.18% <ø> (ø)
projmgr-cov 81.45% <68.52%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrRpcServerData.h 100.00% <ø> (+100.00%) ⬆️
tools/projmgr/include/ProjMgrWorker.h 77.27% <ø> (ø)
tools/projmgr/src/ProjMgrWorker.cpp 88.28% <87.50%> (ø)
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp 65.61% <0.00%> (ø)
tools/projmgr/src/ProjMgrRpcServer.cpp 59.00% <80.76%> (+17.74%) ⬆️
tools/projmgr/src/ProjMgrRpcServerData.cpp 80.09% <65.45%> (+80.09%) ⬆️
tools/projmgr/test/src/ProjMgrRpcTests.cpp 66.27% <63.19%> (-5.15%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants