Skip to content

[csolution] Handle cmd line option --active= (empty argument)#2167

Merged
brondani merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/csolution-handle-active-target-set-empty
Jul 30, 2025
Merged

[csolution] Handle cmd line option --active= (empty argument)#2167
brondani merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/csolution-handle-active-target-set-empty

Conversation

@grasci-arm

@grasci-arm grasci-arm commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator

Accept command line option --active with empty argument, implicitly taking the first target-type as the active one.
Being --active a "string option" rather than a "boolean flag", to be correctly parsed the "empty argument" needs to be in one of the formats:

--active=
--active ""
-a ""

Note -a= is not supported. In such case = is literally the argument.

Align with Open-CMSIS-Pack/cbuild#443

[csolution] Handle cmd line option --active "" (empty argument)
@github-actions

Copy link
Copy Markdown

Test Results

    3 files     21 suites   13m 10s ⏱️
  418 tests   418 ✅ 0 💤 0 ❌
1 254 runs  1 254 ✅ 0 💤 0 ❌

Results for commit caf6bd6.

@brondani brondani merged commit a2292a0 into Open-CMSIS-Pack:main Jul 30, 2025
32 of 33 checks passed
@brondani brondani deleted the outbound/csolution-handle-active-target-set-empty branch July 30, 2025 14:54
@codecov

codecov Bot commented Jul 30, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (527049f) to head (caf6bd6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrUnitTests.cpp 50.00% 0 Missing and 3 partials ⚠️
tools/projmgr/src/ProjMgrWorker.cpp 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2167   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files         181      181           
  Lines       38377    38389   +12     
  Branches    22483    22493   +10     
=======================================
+ Hits        25560    25568    +8     
  Misses       8082     8082           
- Partials     4735     4739    +4     
Flag Coverage Δ
projmgr-cov 80.80% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgr.h 100.00% <ø> (ø)
tools/projmgr/src/ProjMgr.cpp 80.20% <100.00%> (ø)
tools/projmgr/src/ProjMgrWorker.cpp 87.83% <71.42%> (-0.01%) ⬇️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 80.36% <50.00%> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants