Skip to content

[projmgr] Fix yml comparison to avoid rewriting files #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brondani merged 1 commit into from
Jul 31, 2025
Merged

[projmgr] Fix yml comparison to avoid rewriting files #2170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/projmgr/src/ProjMgrYamlEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@ bool ProjMgrYamlEmitter::CompareFile(const string& filename, const YAML::Node& r
return false;
}
const YAML::Node& yamlRoot = YAML::LoadFile(filename);
return CompareNodes(yamlRoot, rootNode);

// emit and load rootNode to ensure both comparison sides have the same formatting
YAML::Emitter emitter;
return CompareNodes(yamlRoot, YAML::Load((emitter << rootNode).c_str()));
}

bool ProjMgrYamlEmitter::CompareNodes(const YAML::Node& lhs, const YAML::Node& rhs) {
Expand Down
Loading