Skip to content

[projmgr] Add ConvertSolution, update LoadSolution and GetVersion RPC methods#2187

Merged
brondani merged 2 commits into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/projmgr-loadsolution-activetarget
Aug 20, 2025
Merged

[projmgr] Add ConvertSolution, update LoadSolution and GetVersion RPC methods#2187
brondani merged 2 commits into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/projmgr-loadsolution-activetarget

Conversation

@grasci-arm

@grasci-arm grasci-arm commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Address Open-CMSIS-Pack/cmsis-toolbox#406
Start addressing Open-CMSIS-Pack/cmsis-toolbox#408

  • Handle LoadSolution method request with activeTarget parameter
  • Add apiVersion to GetVersion method response
  • AddConvertSolution method handling

@brondani brondani changed the title outbound/projmgr loadsolution activetarget [projmgr] Add ConvertSolution, update LoadSolution and GetVersion RPC methods Aug 20, 2025
@brondani brondani changed the title [projmgr] Add ConvertSolution, update LoadSolution and GetVersion RPC methods [projmgr] Add ConvertSolution, update LoadSolution and GetVersion RPC methods Aug 20, 2025
@github-actions

Copy link
Copy Markdown

Test Results

    3 files     21 suites   14m 9s ⏱️
  421 tests   421 ✅ 0 💤 0 ❌
1 263 runs  1 263 ✅ 0 💤 0 ❌

Results for commit 09ee3c3.

@brondani brondani merged commit 3e0a1ea into Open-CMSIS-Pack:main Aug 20, 2025
33 checks passed
@brondani brondani deleted the outbound/projmgr-loadsolution-activetarget branch August 20, 2025 14:50
@codecov

codecov Bot commented Aug 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.10526% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.61%. Comparing base (0709443) to head (09ee3c3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrRpcTests.cpp 66.66% 0 Missing and 14 partials ⚠️
tools/projmgr/src/ProjMgrRpcServer.cpp 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   66.60%   66.61%   +0.01%     
==========================================
  Files         181      181              
  Lines       38417    38476      +59     
  Branches    22511    22556      +45     
==========================================
+ Hits        25586    25632      +46     
- Misses       8080     8081       +1     
- Partials     4751     4763      +12     
Flag Coverage Δ
projmgr-cov 80.76% <82.10%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgr.h 100.00% <ø> (ø)
tools/projmgr/src/ProjMgr.cpp 80.37% <100.00%> (+0.17%) ⬆️
tools/projmgr/test/src/ProjMgrTestEnv.cpp 76.76% <100.00%> (+2.46%) ⬆️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 80.28% <ø> (-0.07%) ⬇️
tools/projmgr/src/ProjMgrRpcServer.cpp 67.04% <86.36%> (+0.84%) ⬆️
tools/projmgr/test/src/ProjMgrRpcTests.cpp 56.18% <66.66%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants