Skip to content

Fix SelectBundle to return true if changed and no error (#1328)#2232

Merged
jkrech merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/SelectBundleResult
Oct 10, 2025
Merged

Fix SelectBundle to return true if changed and no error (#1328)#2232
jkrech merged 1 commit into
Open-CMSIS-Pack:mainfrom
ARM-software:outbound/SelectBundleResult

Conversation

@grasci-arm

Copy link
Copy Markdown
Collaborator

Add tests for SelectBundle

@github-actions

Copy link
Copy Markdown

Test Results

    3 files     21 suites   13m 0s ⏱️
  424 tests   424 ✅ 0 💤 0 ❌
1 272 runs  1 272 ✅ 0 💤 0 ❌

Results for commit 119a02e.

@jkrech jkrech self-requested a review October 10, 2025 10:26

@jkrech jkrech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech merged commit 3e41d7c into Open-CMSIS-Pack:main Oct 10, 2025
33 checks passed
@jkrech jkrech deleted the outbound/SelectBundleResult branch October 10, 2025 10:27
@codecov

codecov Bot commented Oct 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.77%. Comparing base (87fa485) to head (119a02e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/test/src/ProjMgrRpcTests.cpp 75.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
+ Coverage   66.74%   66.77%   +0.03%     
==========================================
  Files         181      181              
  Lines       38681    38711      +30     
  Branches    22687    22711      +24     
==========================================
+ Hits        25816    25850      +34     
+ Misses       8087     8078       -9     
- Partials     4778     4783       +5     
Flag Coverage Δ
projmgr-cov 80.93% <80.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrRpcServer.cpp 69.82% <100.00%> (+2.63%) ⬆️
tools/projmgr/test/src/ProjMgrRpcTests.cpp 57.26% <75.00%> (+0.75%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants