Skip to content

shorten message#2251

Merged
brondani merged 6 commits into
mainfrom
min_version_check_message
Oct 27, 2025
Merged

shorten message#2251
brondani merged 6 commits into
mainfrom
min_version_check_message

Conversation

@jkrech

@jkrech jkrech commented Oct 27, 2025

Copy link
Copy Markdown
Member

addressing comment: #2234 (comment)

addressing comment: #2234 (comment)
@jkrech jkrech requested a review from brondani October 27, 2025 10:42

@brondani brondani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case must be updated accordingly:

const string& expectedErrMsg = "error csolution: the 'created-for' node in file .*created-for\\.csolution\\.yml\
specifies a minimum version 9\\.9\\.9 which is higher than .* of the used CMSIS-Toolbox manifest\n";

jkrech and others added 2 commits October 27, 2025 12:07
Co-authored-by: Daniel Brondani <daniel.brondani@arm.com>
Comment thread tools/projmgr/src/ProjMgr.cpp Outdated
brondani
brondani previously approved these changes Oct 27, 2025

@brondani brondani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tools/projmgr/test/src/ProjMgrUnitTests.cpp Outdated
brondani
brondani previously approved these changes Oct 27, 2025
Comment thread tools/projmgr/src/ProjMgr.cpp Outdated
@github-actions

Copy link
Copy Markdown

Test Results

    3 files     21 suites   14m 26s ⏱️
  427 tests   427 ✅ 0 💤 0 ❌
1 281 runs  1 281 ✅ 0 💤 0 ❌

Results for commit 80628b9.

@brondani brondani merged commit 607a565 into main Oct 27, 2025
33 checks passed
@brondani brondani deleted the min_version_check_message branch October 27, 2025 12:18
@codecov

codecov Bot commented Oct 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.21%. Comparing base (93e18f8) to head (80628b9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2251      +/-   ##
==========================================
+ Coverage   66.18%   66.21%   +0.02%     
==========================================
  Files         181      181              
  Lines       36213    36251      +38     
  Branches    22453    22483      +30     
==========================================
+ Hits        23968    24002      +34     
+ Misses       7681     7678       -3     
- Partials     4564     4571       +7     
Flag Coverage Δ
projmgr-cov 80.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgr.cpp 80.02% <100.00%> (ø)
tools/projmgr/test/src/ProjMgrUnitTests.cpp 79.12% <100.00%> (+0.04%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants