[projmgr] Improve duplicate components in cproject/clayer.yml#2396
Merged
brondani merged 6 commits intoMar 16, 2026
Merged
Conversation
Test Results 3 files 21 suites 16m 34s ⏱️ Results for commit 463e19d. ♻️ This comment has been updated with latest results. |
jthuangarm
force-pushed
the
csolution-duplicated-components
branch
from
f2fa330 to
8b5da3f
Compare
brondani
reviewed
Mar 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
==========================================
- Coverage 64.66% 64.64% -0.03%
==========================================
Files 145 145
Lines 26097 26093 -4
Branches 15747 15743 -4
==========================================
- Hits 16876 16868 -8
+ Misses 7069 7065 -4
- Partials 2152 2160 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1197
As the error message from
YmlSchemaCheckeris triggered before the error message fromAddComponent()in ProjMgrWorker.cpp, remove theuniqueItemsconstraint fromComponentsTypein common.schema.json. This enables duplicate components to be handled explicitly in the code, resulting in a more detailed message.Added a new unit test (
DuplicateComponents) in ProjMgrUnitTests.cpp. Two use cases with and without--no-check-schema:duplicateComponents_cproject: duplicate components in the same YAML file (both in cproject.yml)duplicateComponents_clayer: duplicate components in the different YAML files (one in cproject.yml, the other in clayer.yml)