Skip to content

[projmgr] Add download-url into error reporting for external generator failures#2414

Merged
brondani merged 7 commits into
Open-CMSIS-Pack:mainfrom
jthuangarm:cbridge-url
Mar 26, 2026
Merged

[projmgr] Add download-url into error reporting for external generator failures#2414
brondani merged 7 commits into
Open-CMSIS-Pack:mainfrom
jthuangarm:cbridge-url

Conversation

@jthuangarm

@jthuangarm jthuangarm commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Fix: Open-CMSIS-Pack/vscode-cmsis-solution#104

  • Updated ProjMgrWorker::ExecuteExtGenerator to log the generator's download URL on failure, or report its absence if not available.
  • Updated the numbers in RteChkTest lib test because of the changes in ProjMgrExtGenerator.h and RteTestGenerator.pdsc

After changes:

  1. Test case where generator returns error
csolution run c:\Projects\Blinky\Blinky.csolution.yml -g InfineonDeviceConfigurator -c Cortex-M0p.Debug+CYT4BF8CDS
error csolution: executing generator 'InfineonDeviceConfigurator' for context 'Cortex-M0p.Debug+CYT4BF8CDS' failed:
  Checking per-user IDC JSON files in C:\Users\jenhua01\AppData\Local\Infineon_Technologies_AG\Infineon-Toolbox...
Per-user directory not found: C:\Users\jenhua01\AppData\Local\Infineon_Technologies_AG\Infineon-Toolbox
Error: Infineon Device-Configurator not found, please download and install from https://softwaretools.infineon.com/tools/com.ifx.tb.tool.deviceconfigurator
  check the URL for downloading the generator: https://softwaretools.infineon.com/tools/com.ifx.tb.tool.deviceconfigurator
  1. Test case where no download-url is found in generator.yml and generator returns error
csolution run c:\Projects\Blinky\Blinky.csolution.yml -g InfineonDeviceConfigurator -c Cortex-M0p.Debug+CYT4BF8CDS
error csolution: executing generator 'InfineonDeviceConfigurator' for context 'Cortex-M0p.Debug+CYT4BF8CDS' failed:
  Checking per-user IDC JSON files in C:\Users\jenhua01\AppData\Local\Infineon_Technologies_AG\Infineon-Toolbox...
Per-user directory not found: C:\Users\jenhua01\AppData\Local\Infineon_Technologies_AG\Infineon-Toolbox
Error: Infineon Device-Configurator not found, please download and install from https://softwaretools.infineon.com/tools/com.ifx.tb.tool.deviceconfigurator
  download URL is not available for generator 'InfineonDeviceConfigurator' in generator.yml
  1. Test case where generator launch successes and runs with --verbose
csolution run c:\Projects\Blinky\Blinky.csolution.yml -g InfineonDeviceConfigurator -c Cortex-M0p.Debug+CYT4BF8CDS --verbose
C:/Projects/Blinky/tmp/Blinky.cbuild-gen-idx.yml - info csolution: file is already up-to-date
C:/Projects/Blinky/tmp/Cortex-M0p.Debug+CYT4BF8CDS.cbuild-gen.yml - info csolution: file is already up-to-date
info csolution: generator 'InfineonDeviceConfigurator' for context 'Cortex-M0p.Debug+CYT4BF8CDS' reported:
  Checking per-user IDC JSON files in C:\Users\jenhua01\AppData\Local\Infineon_Technologies_AG\Infineon-Toolbox...
  "featureId": "com.ifx.tb.tool.deviceconfigurator",
  ...

@github-actions

github-actions Bot commented Mar 25, 2026

Copy link
Copy Markdown

Test Results

  6 files   12 suites   10s ⏱️
 49 tests  49 ✅ 0 💤 0 ❌
147 runs  147 ✅ 0 💤 0 ❌

Results for commit 32f8c33.

♻️ This comment has been updated with latest results.

@jthuangarm jthuangarm marked this pull request as ready for review March 26, 2026 07:49
@jthuangarm jthuangarm requested a review from brondani March 26, 2026 07:50
Comment thread tools/projmgr/src/ProjMgrWorker.cpp Outdated
Comment thread test/packs/ARM/RteTestGenerator/0.1.0/ARM.RteTestGenerator.pdsc Outdated
Comment thread tools/projmgr/src/ProjMgrWorker.cpp Outdated
@jthuangarm

Copy link
Copy Markdown
Contributor Author

Thank you for the suggestions. I have also updated the PR description based on changes. Please review them again.

@jthuangarm jthuangarm requested a review from brondani March 26, 2026 11:35
Comment thread tools/projmgr/src/ProjMgrWorker.cpp Outdated
@jthuangarm jthuangarm requested a review from brondani March 26, 2026 13:07

@brondani brondani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkrech jkrech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit d2240ff into Open-CMSIS-Pack:main Mar 26, 2026
100 of 101 checks passed
@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.72%. Comparing base (95ace1c) to head (32f8c33).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrExtGenerator.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2414      +/-   ##
==========================================
+ Coverage   64.70%   64.72%   +0.02%     
==========================================
  Files         145      145              
  Lines       26127    26137      +10     
  Branches    15767    15774       +7     
==========================================
+ Hits        16905    16918      +13     
+ Misses       7068     7066       -2     
+ Partials     2154     2153       -1     
Flag Coverage Δ
buildmgr-cov 79.87% <ø> (ø)
packchk-cov 69.73% <ø> (ø)
projmgr-cov 87.77% <91.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrExtGenerator.h 100.00% <ø> (ø)
tools/projmgr/src/ProjMgrWorker.cpp 88.21% <100.00%> (+0.12%) ⬆️
tools/projmgr/src/ProjMgrExtGenerator.cpp 83.72% <66.66%> (-1.28%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jthuangarm jthuangarm deleted the cbridge-url branch March 27, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Configuration Generator does not show download URL when IFX Config Tool is missing

3 participants