Skip to content

[projmgr] Throw warning when multiple packs versions are simultaneously selected#2460

Merged
brondani merged 3 commits into
mainfrom
projmgr-check-muitiple-pack-versions
Apr 29, 2026
Merged

[projmgr] Throw warning when multiple packs versions are simultaneously selected#2460
brondani merged 3 commits into
mainfrom
projmgr-check-muitiple-pack-versions

Conversation

@brondani

@brondani brondani commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown

Test Results

    3 files   -    55     21 suites   - 155   15m 43s ⏱️ - 5m 39s
  460 tests  -   450    460 ✅  -   433  0 💤  - 17  0 ❌ ±0 
1 380 runs   - 1 487  1 380 ✅  - 1 419  0 💤  - 68  0 ❌ ±0 

Results for commit 18740ed. ± Comparison against base commit 79b66b5.

This pull request removes 451 and adds 1 tests. Note that renamed tests count towards both.
AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…
ProjMgrUnitTests ‑ MultiplePackVersions

♻️ This comment has been updated with latest results.

Comment thread tools/projmgr/src/ProjMgrWorker.cpp Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds detection and reporting when a solution/context ends up selecting multiple versions of the same pack, improving visibility into conflicting pack requirements.

Changes:

  • Emit a warning during pack filtering if more than one version of the same pack is selected for a context.
  • Add a unit test asserting the warning is produced.
  • Add a new .csolution.yml test input that selects two versions of ARM::RteTest_DFP (one by version, one via path).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tools/projmgr/src/ProjMgrWorker.cpp Tracks selected pack versions per context and warns when multiple versions are selected.
tools/projmgr/test/src/ProjMgrUnitTests.cpp Adds a unit test validating the new warning text appears on stderr.
tools/projmgr/test/data/TestSolution/pack_multiple_versions.csolution.yml New test solution selecting two versions of the same pack to trigger the warning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/projmgr/src/ProjMgrWorker.cpp
Comment thread tools/projmgr/src/ProjMgrWorker.cpp
@brondani brondani marked this pull request as ready for review April 28, 2026 08:55
@brondani brondani requested a review from edriouk April 28, 2026 08:56
@brondani brondani merged commit 281a898 into main Apr 29, 2026
37 checks passed
@brondani brondani deleted the projmgr-check-muitiple-pack-versions branch April 29, 2026 07:59
@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.95%. Comparing base (79b66b5) to head (18740ed).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
+ Coverage   64.93%   64.95%   +0.01%     
==========================================
  Files         145      145              
  Lines       26209    26219      +10     
  Branches    15828    15836       +8     
==========================================
+ Hits        17020    17030      +10     
  Misses       7042     7042              
  Partials     2147     2147              
Flag Coverage Δ
projmgr-cov 88.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.90% <100.00%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants