[projmgr] Throw warning when multiple packs versions are simultaneously selected#2460
Conversation
Test Results 3 files - 55 21 suites - 155 15m 43s ⏱️ - 5m 39s Results for commit 18740ed. ± Comparison against base commit 79b66b5. This pull request removes 451 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
Adds detection and reporting when a solution/context ends up selecting multiple versions of the same pack, improving visibility into conflicting pack requirements.
Changes:
- Emit a warning during pack filtering if more than one version of the same pack is selected for a context.
- Add a unit test asserting the warning is produced.
- Add a new
.csolution.ymltest input that selects two versions ofARM::RteTest_DFP(one by version, one viapath).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/projmgr/src/ProjMgrWorker.cpp | Tracks selected pack versions per context and warns when multiple versions are selected. |
| tools/projmgr/test/src/ProjMgrUnitTests.cpp | Adds a unit test validating the new warning text appears on stderr. |
| tools/projmgr/test/data/TestSolution/pack_multiple_versions.csolution.yml | New test solution selecting two versions of the same pack to trigger the warning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
+ Coverage 64.93% 64.95% +0.01%
==========================================
Files 145 145
Lines 26209 26219 +10
Branches 15828 15836 +8
==========================================
+ Hits 17020 17030 +10
Misses 7042 7042
Partials 2147 2147
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes
Checklist