Skip to content

[CI] Skip QLTY publish on fork PRs#118

Merged
JonatanAntoni merged 4 commits into
mainfrom
publish-coverage
Jun 18, 2026
Merged

[CI] Skip QLTY publish on fork PRs#118
JonatanAntoni merged 4 commits into
mainfrom
publish-coverage

Conversation

@soumeh01

@soumeh01 soumeh01 commented May 20, 2026

Copy link
Copy Markdown
Contributor

Change

  • OIDC tokens are unavailable/restricted for fork PRs, so upload actions that require OIDC fail there
  • This condition skips that step on fork PRs, but still allows it on
    • External fork PR -> skipped
    • Internal PR from a branch in the same repo -> runs
    • Push to main -> runs
    • Release workflow -> skipped
    • Dependabot PR -> skipped
  • Added an enforcement step in the same cov job that reads cov.xml and fails CI on low coverage.

@qltysh

qltysh Bot commented May 20, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@soumeh01 soumeh01 force-pushed the publish-coverage branch 5 times, most recently from a88daac to 4edcd53 Compare May 20, 2026 09:35
@soumeh01 soumeh01 changed the title [WIP] [CI] Skip QLTY publish on fork PRs [CI] Skip QLTY publish on fork PRs May 20, 2026
@soumeh01 soumeh01 marked this pull request as ready for review May 20, 2026 09:37
@soumeh01 soumeh01 requested review from JonatanAntoni and removed request for JonatanAntoni May 20, 2026 09:37
@soumeh01 soumeh01 marked this pull request as draft May 20, 2026 09:49
@soumeh01 soumeh01 force-pushed the publish-coverage branch from 4edcd53 to 735837d Compare May 20, 2026 09:49
@qltysh

qltysh Bot commented May 20, 2026

Copy link
Copy Markdown

All good ✅

Comment thread .github/workflows/tests.yml
Comment thread .github/workflows/tests.yml
Comment thread .github/workflows/tests.yml Outdated
@soumeh01 soumeh01 force-pushed the publish-coverage branch from fdb332e to 5a349fd Compare May 20, 2026 10:16
Comment thread .github/workflows/tests.yml
@soumeh01 soumeh01 force-pushed the publish-coverage branch from 5a349fd to 64ded7b Compare May 20, 2026 11:09
@soumeh01 soumeh01 marked this pull request as ready for review May 20, 2026 11:34
@JonatanAntoni JonatanAntoni merged commit cf9a50a into main Jun 18, 2026
14 checks passed
@JonatanAntoni JonatanAntoni deleted the publish-coverage branch June 18, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants