Skip to content

Hide unavailable view actions and improve filter cancellation#1018

Merged
jreineckearm merged 58 commits into
mainfrom
webview-buttonFilter
Jun 19, 2026
Merged

Hide unavailable view actions and improve filter cancellation#1018
jreineckearm merged 58 commits into
mainfrom
webview-buttonFilter

Conversation

@jthuangarm

@jthuangarm jthuangarm commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Stacked PR on top of PR#926.
Blocked until PR#926 is merged, and will be rebased to main afterwards.

Changes

  • Hide toolbar and Command Palette actions when they are not usable:

    • No active debug session: hide inactive view actions.
    • AUX GDB unavailable: hide Enable/Disable Periodic Update.
  • Filtering behavior is more predictable:

    • Deleting the text to fix a mistake no longer closes the filter box by itself.
    • Enter confirms the current text.
    • Escape cancels the edit and restores the previous filter.
    • Workspace settings should be synced as well.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

thorstendb-ARM and others added 30 commits March 25, 2026 09:48
Base automatically changed from filterEntriesSmart to main June 19, 2026 09:41
@qltysh

qltysh Bot commented Jun 19, 2026

Copy link
Copy Markdown

All good ✅

Comment thread src/webviews/tree-table/src/TreeTable.tsx Outdated
Comment thread src/webviews/tree-table/src/TreeTable.tsx Outdated
Comment thread src/webviews/tree-table/src/TreeTable.tsx Outdated
Comment thread src/webviews/tree-table/src/TreeTable.tsx Outdated
@jthuangarm jthuangarm requested a review from jreineckearm June 19, 2026 10:16
Comment thread package-lock.json Outdated

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look good and work as expected! Nice work

@jreineckearm jreineckearm merged commit a80cb5b into main Jun 19, 2026
21 checks passed
@jreineckearm jreineckearm deleted the webview-buttonFilter branch June 19, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants