Skip to content

Enhance CMSIS pack root access by introducing a fallback mechanism and improving error messages#90

Merged
arneschmid merged 3 commits into
mainfrom
improve/pack-root-access
Jun 24, 2026
Merged

Enhance CMSIS pack root access by introducing a fallback mechanism and improving error messages#90
arneschmid merged 3 commits into
mainfrom
improve/pack-root-access

Conversation

@arneschmid

@arneschmid arneschmid commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Fixes

  • #

Changes

  • Fix path resolution for default and custom cmsis pack root folder

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@arneschmid arneschmid requested a review from brondani June 23, 2026 07:39

@brondani brondani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the long run we should consider improving code reuse across our repositories. For example, getCmsisPackRoot is already implemented in vscode-cmsis-solution:
https://github.com/Open-CMSIS-Pack/vscode-cmsis-solution/blob/0a7190fdeb44df0d9e08ed695701ede7b4af7cc2/src/utils/path-utils.ts#L50

@arneschmid arneschmid merged commit 5218843 into main Jun 24, 2026
12 checks passed
@arneschmid arneschmid deleted the improve/pack-root-access branch June 24, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants