Fix/potential file system race#91
Merged
Merged
Conversation
…n message handlers
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses code scanning findings by hardening webview message handling (origin verification) and reducing TOCTOU-style filesystem patterns when creating config/metadata files.
Changes:
- Added
event.originverification to multiple webviewmessagehandlers. - Switched config/metadata creation to atomic file creation (
fs.writeFileSync(..., { flag: 'wx' })) withEEXISThandling. - Reworked workspace config seeding logic in
ensureWorkspaceConfigFile(but the current approach likely breaks the “open config outside workspace then openFolder” flow).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/webview/bridge.ts | Adds origin verification to the shared webview message bridge handler. |
| src/viewer/webview/dataViewerApp.tsx | Adds origin verification to viewer app message handler. |
| src/viewer/webview/components/frameWindowViewer.ts | Adds origin verification to frame window viewer message handler. |
| src/viewer/webview/components/audioViewer.tsx | Adds origin verification to audio viewer message handler. |
| src/extension.ts | Replaces direct .vscode/settings.json seeding with workspace.getConfiguration().update() (introduces a likely functional regression). |
| src/commands/sdsioConfigCommands.ts | Uses atomic file creation for new config files and handles EEXIST. |
| src/commands/sdsFileCommands.ts | Uses atomic file creation for metadata template and handles EEXIST. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thorstendb-ARM
approved these changes
Jun 23, 2026
thorstendb-ARM
left a comment
There was a problem hiding this comment.
LGTM, try/catch are added to file access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Changes
Screenshots
Checklist