Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add processToJSON for convenience #114

Merged
merged 39 commits into from
Apr 28, 2022
Merged

add processToJSON for convenience #114

merged 39 commits into from
Apr 28, 2022

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Feb 22, 2022

For context see Open-EO/openeo.org#56

flahn added 9 commits February 11, 2022 17:51
@flahn
fixed error handling with httr2
df70661
@flahn
initial sampling replacing spatial extent in a process
a2896c6
@flahn
start job returns the modified job object
d969529
@flahn
FileFormat set to Argument is now serialized as its name
3b2cbc8
@flahn
get_sample now executes sync or async
109dfe2
@flahn
added coerce to data.frame of the ResultList
f6b4aeb
@flahn
fixes #108
6f06b7e 
* download.file() was replaced by httr2 methods
* parameter job can also be AssetList or ResultList and not NULL
@flahn
enabled print the query via httr2's dry run in debug mode
1ba9b08
@flahn
mostly solves #94 and #39
c312b5c 
* compute_results has now parameters 'as_stars' and 'format' to open the
data as stars object
* 'output_file' can be omitted, if so a temporary file will be created
@m-mohr m-mohr added this to the v1.2.0 milestone Feb 22, 2022
@m-mohr m-mohr requested a review from flahn February 22, 2022 10:34
@m-mohr m-mohr mentioned this pull request Feb 22, 2022
Closed
@flahn
Copy link
Member

flahn commented Feb 22, 2022 •
edited
Loading

I am not sure if we need this. Printing a process to console should already give you a JSON. If you want it printed to a file, I would suggest to overload as.list(x) somehow, where you handle the serialization. Depending on the json package the user has installed, they can use it as they like. Probably all json packages know how to deal with lists.

@m-mohr
Copy link
Member Author

m-mohr commented Feb 23, 2022

Open for alternatives, but it seems to be an issue though as you can see in the PR. 3 persons had a hard time figuring out how to solve the issue, it took me like 20mins to figure out what to use so help is needed in some shape or form.

flahn added 14 commits February 25, 2022 10:47
@flahn
keep sample data if output_file was specified
e3714a7
@flahn
solves #62
73ba63b 
* in `compute_result` we set the save_result node automatically or
replace the already set node with the arguments given to compute_result
@flahn
modified verification_uri selection as revised in the PR
649f892
@flahn
allow bbox the be any crs on get sample
4a36dfe
@flahn
Merge branch 'feature/sample_data' into develop
c1704fe
@flahn
first sample_data vignette draft
849c4d4
@flahn
fixed problem in center calculation of get_sample
4dea8f3
@flahn
added new section in the vignette of get_sample
8eb1a1b
@flahn
fixed property list parsing (Metadata-Filter)
21ae1af
@flahn
update on sample vignette
2000855
@flahn
first try to improve spatial handling
9f7b3de
@flahn
updated NEWS
eab014a
@flahn
Merge branch 'develop' into feature/sample_spatial_objects
fe4f871
@flahn
fixes for the spatial object handling
b8cf058 
* fixed param spatial_extent handling on get_sample
* fixes on transforming sf objects from and to GeoJSON
* removed suggested connection to package geojsonsf which can also be
handled by sf directly
flahn and others added 15 commits March 24, 2022 16:50
@flahn
Merge branch 'feature/sample_spatial_objects' into develop
8ec19f4
@flahn
changed the serialization behavior of geojson
b6d1d0e 
* now forcing the coodinates to follow the GeoJSON specification as CRS
to be CRS84 and axis order to be latitude / longitude; also removing the
crs field in the serialization
@flahn
fixed issue translating geojson -> sf object, axis swap
1e40d45
@flahn
solves #116 - device code authentication
5dfa454 
* added authentication support for
urn:ietf:params:oauth:grant-type:device_code if the authentication
provider supports it
@m-mohr
Use with_interactive so that auth works with Jupyter #95 #118
83a5fb5
@flahn
disable digit property on toJSON
e84d346 
* relates to
#64 (comment)
@flahn
access values of parameter directly where different arguments are
75dd692 
allowed
@flahn
Merge branch 'with_interactive' into develop
218d6c0
@flahn
added exported method in namespace
0eb92a3
@flahn
added a section for configuration options on login #116
f194ba8
@flahn
provide coerce function for Job to Process (#115)
f8f2700
@flahn
fixed parameter of process node access in get_sample
b29a88f
@flahn
Merge branch 'develop' into processToJSON
f9859d9 
Conflicts:
	NEWS.md
	R/utilities.R
@flahn
made toJSON generic for process and graph
e93de7f 
* marked processToJSON and graphToJSON as deprecated
@flahn
created deprecation warnings for:
6295f7d 
* client$login(login_type,...)
* create_user_process(submit,...)
@flahn flahn merged commit 6295f7d into develop Apr 28, 2022
@flahn
Copy link
Member

flahn commented Apr 28, 2022

updated/merged the PR, processToJSON is now also available, but will be immediately marked as deprecated - as is graphToJSON. Use for this purpose openeos toJSON function (implemented for objects Process and Graph)

@m-mohr m-mohr deleted the processToJSON branch April 28, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flahn flahn Awaiting requested review from flahn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@m-mohr @flahn